-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide a logrotate conf for subagent logs #254
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to ask — what about Windows? Wouldn't it suffer from the same issues?
I'll address the comments shortly. I haven't used it on Windows and don't know, but it looks like fluent-bit is configured to produce a log file on Windows as well? In that case I'd assume yes. Windows doesn't have logrotate so we would need to work around it (I think many services use the system event log instead of local files). |
We have a fleet of RHEL and OEL machines affected by this issue, and while @igorpeshansky's suggestion to implement Windows log rotation is made in good faith, it may be the perfect preventing good from happening. I think that Windows log rotation is a valid thing to ask for, but can we merge the Linux–only log rotation for the time being since the log files in the wild are not getting any smaller? |
I just investigated an issue with one of the VMs running out of space and the culprit was the logging from the agent resulted in 22G file. Please merge this. |
I don't know why the check is failing. I didn't change anything about Windows but somehow it's Windows that's failing? Let me know if there's anything I can do. |
The rationale is provided in #251. This PR adds a default logrotate conf for Linux packages.
The config is based on the default debian syslog rule, and does:
We don't need to restart fluent-bit because currently fluent-bit opens and closes log files every time it writes something.