-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds MySQL 8.4 3rd Party Integration tests #1825
base: master
Are you sure you want to change the base?
Conversation
51cbc57
to
e3cae55
Compare
e3cae55
to
0bbba5f
Compare
0bbba5f
to
7fdcf29
Compare
7fdcf29
to
7ab34a6
Compare
7ab34a6
to
2717134
Compare
2717134
to
7f2b4b3
Compare
7f2b4b3
to
e858d12
Compare
e858d12
to
ab6beae
Compare
ab6beae
to
e9601d7
Compare
75d1a33
to
3f3086c
Compare
3f3086c
to
102d0df
Compare
@@ -32,11 +32,28 @@ minimum_supported_agent_version: | |||
logging: 2.5.0 | |||
supported_operating_systems: linux | |||
platforms_to_skip: | |||
# MySQL is not currently supported on various distros. | |||
# MySQL is not currently supported on various distros. - ml-images:common-gpu-debian-11-py310 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo in comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: should have the copyright header
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a features.yaml
to the new mysql/
directory as well? I assume it'll just be a copy of this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this intended to work on openSUSE as well? If so then I'll try to put it through a manual test run since the presubmits don't run openSUSE; if not then openSUSE should be added to the skipped platforms.
- suse-cloud:sles-15-arm64 | ||
supported_app_version: ["5.7", "8.0"] | ||
supported_app_version: ["5.7", "8.0", "8.4"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This bit will update our public docs; I would hold off making this change until we've finished adding the other (Debian, Ubuntu, RH, etc.) distros to the tests. (Those other distros can be added in follow-up PRs later since this one was just focused on SLES 15.)
Description
Adds Mysql 8.4 Support for SLES 15. Moves existing mysql 3rd party tests to a new mysql 8.0 directory.
Related issue
How has this been tested?
Checklist: