Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds MySQL 8.4 3rd Party Integration tests #1825

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

StefanKurek
Copy link
Collaborator

@StefanKurek StefanKurek commented Nov 7, 2024

Description

Adds Mysql 8.4 Support for SLES 15. Moves existing mysql 3rd party tests to a new mysql 8.0 directory.

Related issue

How has this been tested?

Checklist:

  • Unit tests
    • Unit tests do not apply.
    • Unit tests have been added/modified and passed for this PR.
  • Integration tests
    • Integration tests do not apply.
    • Integration tests have been added/modified and passed for this PR.
  • Documentation
    • This PR introduces no user visible changes.
    • This PR introduces user visible changes and the corresponding documentation change has been made.
  • Minor version bump
    • This PR introduces no new features.
    • This PR introduces new features, and there is a separate PR to bump the minor version since the last release already.
    • This PR bumps the version.

@StefanKurek StefanKurek added the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 7, 2024
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 7, 2024
@StefanKurek StefanKurek added the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 7, 2024
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 7, 2024
@StefanKurek StefanKurek added the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 7, 2024
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 7, 2024
@StefanKurek StefanKurek added the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 7, 2024
@StefanKurek StefanKurek marked this pull request as ready for review November 7, 2024 20:27
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 7, 2024
@StefanKurek StefanKurek added the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 14, 2024
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 14, 2024
@StefanKurek StefanKurek added the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 14, 2024
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 14, 2024
@StefanKurek StefanKurek added the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 14, 2024
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 14, 2024
@StefanKurek StefanKurek added the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 14, 2024
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 14, 2024
@StefanKurek StefanKurek added the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 18, 2024
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 18, 2024
@StefanKurek StefanKurek added the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 20, 2024
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 20, 2024
@StefanKurek StefanKurek added the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 26, 2024
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 26, 2024
@StefanKurek StefanKurek added the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 27, 2024
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Nov 27, 2024
@StefanKurek StefanKurek added the kokoro:force-run Forces kokoro to run integration tests on a CL label Dec 9, 2024
@stackdriver-instrumentation-release stackdriver-instrumentation-release removed the kokoro:force-run Forces kokoro to run integration tests on a CL label Dec 9, 2024
@@ -32,11 +32,28 @@ minimum_supported_agent_version:
logging: 2.5.0
supported_operating_systems: linux
platforms_to_skip:
# MySQL is not currently supported on various distros.
# MySQL is not currently supported on various distros. - ml-images:common-gpu-debian-11-py310
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in comment

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: should have the copyright header

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a features.yaml to the new mysql/ directory as well? I assume it'll just be a copy of this one.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this intended to work on openSUSE as well? If so then I'll try to put it through a manual test run since the presubmits don't run openSUSE; if not then openSUSE should be added to the skipped platforms.

- suse-cloud:sles-15-arm64
supported_app_version: ["5.7", "8.0"]
supported_app_version: ["5.7", "8.0", "8.4"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bit will update our public docs; I would hold off making this change until we've finished adding the other (Debian, Ubuntu, RH, etc.) distros to the tests. (Those other distros can be added in follow-up PRs later since this one was just focused on SLES 15.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants