-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't throw and exception when raise on error is set to false #293
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
@Tasty213 can you sign the CLA? |
I think I've already done so? The check shows as passed |
fixed the linter error |
/gcbrun |
Could've sworn the linter passed locally |
...ry-resourcedetector-gcp/src/opentelemetry/resourcedetector/gcp_resource_detector/__init__.py
Outdated
Show resolved
Hide resolved
Could be some weird flake in the CI setup. Lmk if you have trouble getting it to pass in CI and I can try to fix it |
Figured out what was wrong with my local testing, I use Windows and have git to checkout CRLF and commit LF, so when I ran the linter locally every single file threw a warning as it was in the 'wrong' line ending style giving pylint unexpected-line-ending-format. I've set pycharm to force everything in the project to LF but now git reckons I've changed every file (until I try and stage and it realises I haven't). Either way this should now pass the lint step. |
/gcbrun |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing!
As raised in #276 and in compliance with the specification make it so that running the detect method on a detector with
raise_on_error
set to false doesn't throw an exception if it can't find any GCP resources.