fix(resource-detector): map metadata server's instanceID to faas.id instead of faas.instance_id #638
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches the current Go/collector impl:
faas.go
in operations-gogcp.go
in collector-contribThis looks like a bug copied from the original Go impl https://github.com/GoogleCloudPlatform/opentelemetry-operations-go/blob/4e508ee3bbb979320283005464642e7d1afd0842/detectors/gcp/faas.go#L59-L62