Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resource-detector): map metadata server's instanceID to faas.id instead of faas.instance_id #638

Closed
wants to merge 1 commit into from

Conversation

aabmass
Copy link
Contributor

@aabmass aabmass commented Oct 5, 2023

@aabmass aabmass changed the title fix(resource-detector): map metadata servers instanceID to faas.id instead of faas.instance_id fix(resource-detector): map metadata server's instanceID to faas.id instead of faas.instance_id Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #638 (a2e4e8d) into main (2e789b0) will not change coverage.
The diff coverage is 100.00%.

❗ Current head a2e4e8d differs from pull request most recent head 93f6316. Consider uploading reports for the commit 93f6316 to get more accurate results

@@           Coverage Diff           @@
##             main     #638   +/-   ##
=======================================
  Coverage   97.69%   97.69%           
=======================================
  Files          18       18           
  Lines         693      693           
  Branches      129      129           
=======================================
  Hits          677      677           
  Misses         16       16           
Files Coverage Δ
...entelemetry-resource-util/src/detector/detector.ts 100.00% <100.00%> (ø)
...s/opentelemetry-resource-util/src/detector/faas.ts 96.15% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@aabmass
Copy link
Contributor Author

aabmass commented Oct 5, 2023

@aabmass
Copy link
Contributor Author

aabmass commented Oct 5, 2023

Oops I'm just confused GoogleCloudPlatform/opentelemetry-operations-go#679

@aabmass aabmass closed this Oct 5, 2023
@aabmass aabmass deleted the instance-to-id branch October 5, 2023 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant