Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use faas.instance instead of faas.id in resource detectors #600

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

dashpole
Copy link
Contributor

@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #600 (39bd501) into main (f72e2e1) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 39bd501 differs from pull request most recent head b829e8d. Consider uploading reports for the commit b829e8d to get more accurate results

@@           Coverage Diff           @@
##             main     #600   +/-   ##
=======================================
  Coverage   97.68%   97.68%           
=======================================
  Files          18       18           
  Lines         691      691           
  Branches      127      127           
=======================================
  Hits          675      675           
  Misses         16       16           
Files Changed Coverage Δ
packages/opentelemetry-resource-util/src/index.ts 100.00% <ø> (ø)
...entelemetry-resource-util/src/detector/detector.ts 100.00% <100.00%> (ø)
...s/opentelemetry-resource-util/src/detector/faas.ts 96.15% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dashpole dashpole marked this pull request as ready for review August 14, 2023 20:01
@dashpole dashpole requested a review from a team as a code owner August 14, 2023 20:01
@aabmass aabmass changed the title Use faas.instance instead of faas.id in resource detectors fix: use faas.instance instead of faas.id in resource detectors (#600) Aug 14, 2023
@aabmass aabmass changed the title fix: use faas.instance instead of faas.id in resource detectors (#600) fix: use faas.instance instead of faas.id in resource detectors Aug 14, 2023
@aabmass aabmass merged commit 4f8f07e into GoogleCloudPlatform:main Aug 14, 2023
@dashpole dashpole deleted the fix_faas_instance branch August 15, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants