Map faas.name and faas.instance to prometheus job and instance for GMP #695
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Step 1 for #679.
Since service.name has a default value, we need faas.name to take precedence over service.name. But I still want to give users the option to override job, so i've opted to add
job
as the override to match other labels.For instance, i've opted to follow the pattern set by name.
In theory, this could be breaking for users if they are setting service.name or service.instance.id on cloud run and expect it to show up. But if we don't take this approach, this doesn't make the migration to the new value seamless for users that followed the example.
Thoughts? @punya @aabmass