Add missing otel attributes to Spans exported to Cloud Trace #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…labels to trace spans.
dashpole
approved these changes
Apr 25, 2022
exporter/trace/go.mod
Outdated
| @@ -31,8 +33,11 @@ require ( | |||
| github.com/googleapis/gax-go/v2 v2.2.0 // indirect | |||
| github.com/pmezard/go-difflib v1.0.0 // indirect | |||
| go.opencensus.io v0.23.0 // indirect | |||
| go.opentelemetry.io/collector/model v0.49.0 // indirect | |||
There was a problem hiding this comment.
This is somewhat unfortunate... The collector and the go SDK have two different packages for semconv. E.g. https://github.com/open-telemetry/opentelemetry-go/tree/main/semconv/v1.9.0 vs https://github.com/open-telemetry/opentelemetry-collector/tree/main/semconv/v1.9.0. I think we should probably use go.opentelemetry.io/otel/semconv/v1.9.0, rather than the collector one. It seems less strange for the collector to depend on the SDK than for the SDK exporter to depend on the collector.
There was a problem hiding this comment.
Ah, good point. I didn't even realize I was pulling the wrong one....
There was a problem hiding this comment.
Hmm, I'm having trouble finding a published version from the SDK -
https://pkg.go.dev/go.opentelemetry.io/otel/semconv/v1.9.0?tab=versions
$ go get go.opentelemetry.io/otel/semconv/v1.9.0
go get: module go.opentelemetry.io/otel@upgrade found (v1.6.3), but does not contain package go.opentelemetry.io/otel/semconv/v1.9.0Should I move back to a version that exists? How often does go publish these?
There was a problem hiding this comment.
Migrated to v1.7.0 (latest released version) of semconv.
damemi
added a commit
that referenced
this pull request
Apr 29, 2022
* Do not use IsZero on timestamps obtained from pdata (#336) * do not use IsZero on timestamps obtained from pdata * send summary counts as doubles instead of integers (#338) * drop data points with no value set (#339) * handle NaN sums in histograms and exponential histograms (#340) * Fix broken links, typos in docs (#345) * Update fixtures based on upstream changes to the prometheus receiver (#346) * update fixtures based on upstream changes to the prometheus receiver * feat(propagator): create a new one-way propagator (#343) * feat(propagator): create a new one-way propagator CloudTraceOneWayPropagator moves trace info from X-cloud-trace-context into 'traceparent'. * Apply suggestions from code review Co-authored-by: David Ashpole <[email protected]> * Update propagator to extract both, emit only traceparent Users will no longer need to create a composite propagator, and there's a clear precedence order between trace headers. Co-authored-by: David Ashpole <[email protected]> * Demonstrate that integration tests aren't catching failures (#349) * demonstrate that integration tests aren't catching failures * Update dependencies (#347) update dependencies * address remaining nits from #347 (#351) * prepare for release (#353) * add integration test with metrics from the prometheus receiver (#348) * add make commands for release (#354) * Send timeseries synchronously (#358) * send timeseries syncronously * update docs, and fix existing broken test * Drop histograms without a sum (#359) * update opentelemetry collector to v0.49.0 * drop histograms without a sum * Add sum of squared deviation estimate (#341) * add sum of squared deviation estimate * Add missing otel attributes to Spans exported to Cloud Trace (#365) * Add instrumentation library to span attributes. * Add test to ensure resource + instrumentation-scope labels show up in spans. * Expand testing. * Move resource mapping into shared module, and add monitored resource labels to trace spans. * Do the go mod tidy shuffle. * Fix docker build to include new shared module. * Bump back to go 1.17 * Migrate to SDK version of semantic convention constants instead of Collector's. * Clean up documents. * Normalize histograms, summaries, and exponential histograms (#360) * normalize remaining cumulative data points * use the timeout passed to the metrics exporter (#369) * make gotidy * Resolve conflicts from missed file Co-authored-by: David Ashpole <[email protected]> Co-authored-by: Marc Dougherty <[email protected]> Co-authored-by: Josh Suereth <[email protected]>
damemi
added a commit
that referenced
this pull request
Apr 29, 2022
* Do not use IsZero on timestamps obtained from pdata (#336) * do not use IsZero on timestamps obtained from pdata * send summary counts as doubles instead of integers (#338) * drop data points with no value set (#339) * handle NaN sums in histograms and exponential histograms (#340) * Fix broken links, typos in docs (#345) * Update fixtures based on upstream changes to the prometheus receiver (#346) * update fixtures based on upstream changes to the prometheus receiver * feat(propagator): create a new one-way propagator (#343) * feat(propagator): create a new one-way propagator CloudTraceOneWayPropagator moves trace info from X-cloud-trace-context into 'traceparent'. * Apply suggestions from code review Co-authored-by: David Ashpole <[email protected]> * Update propagator to extract both, emit only traceparent Users will no longer need to create a composite propagator, and there's a clear precedence order between trace headers. Co-authored-by: David Ashpole <[email protected]> * Demonstrate that integration tests aren't catching failures (#349) * demonstrate that integration tests aren't catching failures * Update dependencies (#347) update dependencies * address remaining nits from #347 (#351) * prepare for release (#353) * add integration test with metrics from the prometheus receiver (#348) * add make commands for release (#354) * Send timeseries synchronously (#358) * send timeseries syncronously * update docs, and fix existing broken test * Drop histograms without a sum (#359) * update opentelemetry collector to v0.49.0 * drop histograms without a sum * Add sum of squared deviation estimate (#341) * add sum of squared deviation estimate * Add missing otel attributes to Spans exported to Cloud Trace (#365) * Add instrumentation library to span attributes. * Add test to ensure resource + instrumentation-scope labels show up in spans. * Expand testing. * Move resource mapping into shared module, and add monitored resource labels to trace spans. * Do the go mod tidy shuffle. * Fix docker build to include new shared module. * Bump back to go 1.17 * Migrate to SDK version of semantic convention constants instead of Collector's. * Clean up documents. * Normalize histograms, summaries, and exponential histograms (#360) * normalize remaining cumulative data points * use the timeout passed to the metrics exporter (#369) Co-authored-by: David Ashpole <[email protected]> Co-authored-by: Marc Dougherty <[email protected]> Co-authored-by: Josh Suereth <[email protected]>
This was referenced May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #332
Turns out we never had a "raw"
Span -> Spantranslation test before now. Imported a few testing libs to make this a thing, and may expand on unit testing other span conversion aspects.