Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main branch into collector_logging #350

Merged
merged 12 commits into from
Apr 11, 2022

Conversation

damemi
Copy link
Contributor

@damemi damemi commented Apr 11, 2022

Following #347, there were merge conflicts (in go.mod/go.sum files) that prevented a basic rebase from being able to merge. Rather than force-push directly to the feature branch, I'm opening this to merge in, resolve the conflicts, and re-run make gotidy

dashpole and others added 11 commits March 28, 2022 15:48
…orm#336)

* do not use IsZero on timestamps obtained from pdata
…oogleCloudPlatform#346)

* update fixtures based on upstream changes to the prometheus receiver
…m#343)

* feat(propagator): create a new one-way propagator

CloudTraceOneWayPropagator moves trace info from X-cloud-trace-context
into 'traceparent'.

* Apply suggestions from code review

Co-authored-by: David Ashpole <[email protected]>

* Update propagator to extract both, emit only traceparent

Users will no longer need to create a composite propagator, and there's
a clear precedence order between trace headers.

Co-authored-by: David Ashpole <[email protected]>
…oudPlatform#349)

* demonstrate that integration tests aren't catching failures
Rebase the collector_logging feature branch onto upstream/main
@damemi damemi requested a review from dashpole April 11, 2022 17:41
Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after linter errors are fixed

@damemi damemi merged commit 49936fa into GoogleCloudPlatform:collector_logging Apr 11, 2022
damemi added a commit to damemi/opentelemetry-operations-go that referenced this pull request Apr 19, 2022
* Do not use IsZero on timestamps obtained from pdata (GoogleCloudPlatform#336)

* do not use IsZero on timestamps obtained from pdata

* send summary counts as doubles instead of integers (GoogleCloudPlatform#338)

* drop data points with no value set (GoogleCloudPlatform#339)

* handle NaN sums in histograms and exponential histograms (GoogleCloudPlatform#340)

* Fix broken links, typos in docs (GoogleCloudPlatform#345)

* Update fixtures based on upstream changes to the prometheus receiver (GoogleCloudPlatform#346)

* update fixtures based on upstream changes to the prometheus receiver

* feat(propagator): create a new one-way propagator (GoogleCloudPlatform#343)

* feat(propagator): create a new one-way propagator

CloudTraceOneWayPropagator moves trace info from X-cloud-trace-context
into 'traceparent'.

* Apply suggestions from code review

Co-authored-by: David Ashpole <[email protected]>

* Update propagator to extract both, emit only traceparent

Users will no longer need to create a composite propagator, and there's
a clear precedence order between trace headers.

Co-authored-by: David Ashpole <[email protected]>

* Demonstrate that integration tests aren't catching failures (GoogleCloudPlatform#349)

* demonstrate that integration tests aren't catching failures

* Update dependencies (GoogleCloudPlatform#347)

update dependencies

* make gotidy

* React to rebase

Co-authored-by: David Ashpole <[email protected]>
Co-authored-by: Marc Dougherty <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants