Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change GMP config recommendations #459

Closed
dashpole opened this issue Jul 25, 2022 · 2 comments
Closed

Change GMP config recommendations #459

dashpole opened this issue Jul 25, 2022 · 2 comments
Assignees
@damemi
Labels
documentation Improvements or additions to documentation enhancement New feature or request priority: p2

Comments

@dashpole
Copy link
Contributor

GMP recently changed how it allows monitored resource labels to be overridden. Previously, if you set project, location, cluster, namespace, it would override the corresponding monitored resource label. However, that can sometimes conflict with labels users have added to their metrics, which do not make sense for the monitored resource (e.g. location=my-basement isn't a valid zone or region). The new recommendation should be:

  • don't recommend promoting project, location, cluster, or namespace using the groupbyattrs processor. Instead, show users how to use the resource processor to hard-code those attributes if needed.
  • Show users how to avoid writing metrics that contain cluster, namespace, location, project, job, or instance labels, since those can break exporting or querying. Instead, users should rename those labels to something else using the transform processor
@jsuereth jsuereth added documentation Improvements or additions to documentation enhancement New feature or request labels Aug 22, 2022
@aabmass
Copy link
Contributor

aabmass commented Dec 14, 2022

@damemi is taking a look

@damemi damemi mentioned this issue Feb 13, 2023
Merged
@damemi
Copy link
Contributor

damemi commented Feb 13, 2023

PR opened upstream open-telemetry/opentelemetry-collector-contrib#18611

codeboten pushed a commit to open-telemetry/opentelemetry-collector-contrib that referenced this issue Feb 15, 2023
@damemi @dashpole
[exporter/googlemanagedprometheus] Update GMP config label recommenda…
789e904 
…tions (#18611)

This changes the recommended config settings for the GMP exporter to not recommend writing your own monitored resource labels, and offering better options to set those if you do need to.

Link to tracking Issue: GoogleCloudPlatform/opentelemetry-operations-go#459
---------

Co-authored-by: David Ashpole <[email protected]>
@damemi damemi closed this as completed Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@damemi damemi

Labels
documentation Improvements or additions to documentation enhancement New feature or request priority: p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jsuereth @aabmass @damemi @dashpole