Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add env variable for storage buckets to test configs #814

Merged
merged 4 commits into from
Mar 12, 2019
Merged

Add env variable for storage buckets to test configs #814

merged 4 commits into from
Mar 12, 2019

Conversation

michaelawyu
Copy link
Contributor

@michaelawyu michaelawyu commented Oct 30, 2018 •
edited
Loading

Do not merge until CL 219352914 is submitted.

Before the CL is merged, tests are expected to fail.

@michaelawyu michaelawyu requested a review from ace-n October 30, 2018 20:14
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 30, 2018
@fhinkel
Copy link
Contributor

fhinkel commented Nov 29, 2018

@michaelawyu Is this something that's still needed? If so, can you have a look at the merge conflicts please. Thanks!

@fhinkel
Copy link
Contributor

fhinkel commented Dec 14, 2018

ping @michaelawyu

@fhinkel
Copy link
Contributor

fhinkel commented Feb 19, 2019

Closed due to inactivity. Please reopen if needed.

@fhinkel fhinkel closed this Feb 19, 2019
@michaelawyu michaelawyu reopened this Mar 5, 2019
@michaelawyu
Copy link
Contributor Author

@ace-n PTAL.

fhinkel
fhinkel approved these changes Mar 6, 2019
View reviewed changes
Copy link
Contributor

@fhinkel fhinkel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks. Is this still "Do not merge"?
The iot failures are unrelated, @hongalex is already working on a fix.

@fhinkel
Copy link
Contributor

fhinkel commented Mar 6, 2019 •
edited
Loading

Could we change the title of the PR (and therefore the squashed commit) to: Add env variable for storage buckets to test configs? Thanks!

@fhinkel fhinkel added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 7, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Mar 7, 2019
@michaelawyu
Copy link
Contributor Author

Thanks :) Title updated.

@michaelawyu michaelawyu changed the title [DO NOT MERGE] Fix failed tests. Add env variable for storage buckets to test configs Mar 9, 2019
@fhinkel fhinkel merged commit c9a178b into master Mar 12, 2019
@fhinkel fhinkel deleted the michaelawyu-patch-kokoro-2 branch March 12, 2019 11:32
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@release-please
chore(main): release 7.0.3 (#817)
b2d1313 
🤖 I have created a release *beep* *boop*
---


## [7.0.3](googleapis/nodejs-translate@v7.0.2...v7.0.3) (2022-09-22)


### Bug Fixes

* Allow passing gax instance to client constructor ([#814](googleapis/nodejs-translate#814)) ([ddc93f9](googleapis/nodejs-translate@ddc93f9))
* **deps:** Update dependency @google-cloud/vision to v3 ([#816](googleapis/nodejs-translate#816)) ([331c65b](googleapis/nodejs-translate@331c65b))
* Preserve default values in x-goog-request-params header ([#820](googleapis/nodejs-translate#820)) ([913ac11](googleapis/nodejs-translate@913ac11))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@release-please
chore(main): release 7.0.3 (#817)
b8bc45b 
🤖 I have created a release *beep* *boop*
---


## [7.0.3](googleapis/nodejs-translate@v7.0.2...v7.0.3) (2022-09-22)


### Bug Fixes

* Allow passing gax instance to client constructor ([#814](googleapis/nodejs-translate#814)) ([ddc93f9](googleapis/nodejs-translate@ddc93f9))
* **deps:** Update dependency @google-cloud/vision to v3 ([#816](googleapis/nodejs-translate#816)) ([331c65b](googleapis/nodejs-translate@331c65b))
* Preserve default values in x-goog-request-params header ([#820](googleapis/nodejs-translate#820)) ([913ac11](googleapis/nodejs-translate@913ac11))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@release-please
chore(main): release 7.0.3 (#817)
66c6a4a 
🤖 I have created a release *beep* *boop*
---


## [7.0.3](googleapis/nodejs-translate@v7.0.2...v7.0.3) (2022-09-22)


### Bug Fixes

* Allow passing gax instance to client constructor ([#814](googleapis/nodejs-translate#814)) ([ddc93f9](googleapis/nodejs-translate@ddc93f9))
* **deps:** Update dependency @google-cloud/vision to v3 ([#816](googleapis/nodejs-translate#816)) ([331c65b](googleapis/nodejs-translate@331c65b))
* Preserve default values in x-goog-request-params header ([#820](googleapis/nodejs-translate#820)) ([913ac11](googleapis/nodejs-translate@913ac11))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n pushed a commit that referenced this pull request Nov 17, 2022
@release-please
chore(main): release 7.0.3 (#817)
cdd4d58 
🤖 I have created a release *beep* *boop*
---


## [7.0.3](googleapis/nodejs-translate@v7.0.2...v7.0.3) (2022-09-22)


### Bug Fixes

* Allow passing gax instance to client constructor ([#814](googleapis/nodejs-translate#814)) ([ddc93f9](googleapis/nodejs-translate@ddc93f9))
* **deps:** Update dependency @google-cloud/vision to v3 ([#816](googleapis/nodejs-translate#816)) ([331c65b](googleapis/nodejs-translate@331c65b))
* Preserve default values in x-goog-request-params header ([#820](googleapis/nodejs-translate#820)) ([913ac11](googleapis/nodejs-translate@913ac11))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
renovate-bot pushed a commit to renovate-bot/nodejs-docs-samples that referenced this pull request Nov 17, 2022
@release-please
chore(main): release 7.0.3 (GoogleCloudPlatform#817)
0e14a3a 
🤖 I have created a release *beep* *boop*
---


## [7.0.3](googleapis/nodejs-translate@v7.0.2...v7.0.3) (2022-09-22)


### Bug Fixes

* Allow passing gax instance to client constructor ([GoogleCloudPlatform#814](googleapis/nodejs-translate#814)) ([ddc93f9](googleapis/nodejs-translate@ddc93f9))
* **deps:** Update dependency @google-cloud/vision to v3 ([GoogleCloudPlatform#816](googleapis/nodejs-translate#816)) ([331c65b](googleapis/nodejs-translate@331c65b))
* Preserve default values in x-goog-request-params header ([GoogleCloudPlatform#820](googleapis/nodejs-translate#820)) ([913ac11](googleapis/nodejs-translate@913ac11))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fhinkel fhinkel fhinkel approved these changes

@ace-n ace-n Awaiting requested review from ace-n

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michaelawyu @fhinkel @googlebot @kokoro-team