Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cloud Healthcare API alpha datasets samples and tests #801
Add Cloud Healthcare API alpha datasets samples and tests #801
Changes from all commits
01d3c4e
c12e2f8
e79592c
8178535
0c10bf5
8aeed2b
f2988d1
930894a
baf32c3
9c20102
3ed95b2
268645f
79bcf99
288368f
9b7bb6f
767e6ff
5c98cbf
85378c7
456d1d4
f74a9ed
ab073a0
9c15d37
a1a2675
d7eaa63
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're not using callbacks in the code. Is there another way to get the client? Not clean to mix the two.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you use default parameters instead of these comments? We usually don't use
adjective-noun-123
butPROJECT_ID
with a TODO for the user to replace it..There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would require
Node 8
and rewrite it withasync/await
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use
mocha
notava
. We're in the process of deletingava
.