Remove engine.node restriction in samples #754
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to pin to a Node version for a Hello World. This will make the sample forward compatible with Node 10
googlebot
added
the
cla: yes
steren
changed the title
steren
changed the title
|
I realize they are all over the place. Let me send another PR |
grayside
pushed a commit
that referenced
this pull request
Nov 11, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [4.1.3](https://www.github.com/googleapis/cloud-profiler-nodejs/compare/v4.1.2...v4.1.3) (2021-07-20) ### Bug Fixes * **deps:** update dependency pprof to v3.2.0 ([#754](https://www.github.com/googleapis/cloud-profiler-nodejs/issues/754)) ([fc48f9a](https://www.github.com/googleapis/cloud-profiler-nodejs/commit/fc48f9aee74a3638d98086e0b404e299ae31b592)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n
pushed a commit
that referenced
this pull request
Nov 12, 2022
🤖 I have created a release \*beep\* \*boop\* --- ### [4.1.3](https://www.github.com/googleapis/cloud-profiler-nodejs/compare/v4.1.2...v4.1.3) (2021-07-20) ### Bug Fixes * **deps:** update dependency pprof to v3.2.0 ([#754](https://www.github.com/googleapis/cloud-profiler-nodejs/issues/754)) ([fc48f9a](https://www.github.com/googleapis/cloud-profiler-nodejs/commit/fc48f9aee74a3638d98086e0b404e299ae31b592)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to pin to a Node version for a Hello World.
This will make the sample forward compatible with Node 10