Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak HTTP sample comments #628

Merged
merged 6 commits into from
Jul 23, 2018
Merged

Tweak HTTP sample comments #628

merged 6 commits into from
Jul 23, 2018

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented May 31, 2018

Do not merge until the requisite docs updates have taken place.

@jmdobry ping me offline if you have questions.

@ace-n ace-n requested a review from jmdobry May 31, 2018 00:51
@ace-n ace-n added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 31, 2018
@codecov
Copy link

codecov bot commented May 31, 2018

Codecov Report

Merging #628 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #628   +/-   ##
=======================================
  Coverage   48.52%   48.52%           
=======================================
  Files           1        1           
  Lines          68       68           
=======================================
  Hits           33       33           
  Misses         35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5188bf...9999ae9. Read the comment docs.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 12, 2018
@ace-n ace-n added the GCF Docs label Jul 12, 2018
@ace-n ace-n removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 23, 2018
@ace-n ace-n merged commit 349b4b7 into master Jul 23, 2018
@ace-n ace-n deleted the http-comments branch August 3, 2018 17:54
ahrarmonsur pushed a commit that referenced this pull request Nov 8, 2022
🤖 I have created a release *beep* *boop*
---


## [3.0.2](googleapis/nodejs-monitoring@v3.0.1...v3.0.2) (2022-09-09)


### Bug Fixes

* Do not import the whole google-gax from proto JS ([#1553](https://github.com/googleapis/nodejs-monitoring/issues/1553)) ([#627](googleapis/nodejs-monitoring#627)) ([647e8ab](googleapis/nodejs-monitoring@647e8ab))
* use google-gax v3.3.0 ([647e8ab](googleapis/nodejs-monitoring@647e8ab))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n pushed a commit that referenced this pull request Nov 10, 2022
🤖 I have created a release *beep* *boop*
---


## [3.0.2](googleapis/nodejs-monitoring@v3.0.1...v3.0.2) (2022-09-09)


### Bug Fixes

* Do not import the whole google-gax from proto JS ([#1553](https://github.com/googleapis/nodejs-monitoring/issues/1553)) ([#627](googleapis/nodejs-monitoring#627)) ([647e8ab](googleapis/nodejs-monitoring@647e8ab))
* use google-gax v3.3.0 ([647e8ab](googleapis/nodejs-monitoring@647e8ab))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
ahrarmonsur pushed a commit that referenced this pull request Nov 16, 2022
ace-n pushed a commit that referenced this pull request Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants