Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add region tags to JWT refresh. #544

Merged
merged 4 commits into from
Jan 3, 2018
Merged

Add region tags to JWT refresh. #544

merged 4 commits into from
Jan 3, 2018

Conversation

noerog
Copy link
Contributor

@noerog noerog commented Jan 3, 2018

No description provided.

@codecov
Copy link

codecov bot commented Jan 3, 2018

Codecov Report

Merging #544 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #544   +/-   ##
=======================================
  Coverage   97.16%   97.16%           
=======================================
  Files          13       13           
  Lines         458      458           
=======================================
  Hits          445      445           
  Misses         13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1af0e36...0a6c039. Read the comment docs.

Copy link
Contributor

@gguuss gguuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, make sure the changes from:

#539

don't conflict, also may be conflicts with

https://github.com/GoogleCloudPlatform/nodejs-docs-samples/tree/tswast-patch-1

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@gguuss
Copy link
Contributor

gguuss commented Jan 3, 2018

@googlebot I signed it!

Checks should be green, both ben and I have signed, merging.

@gguuss gguuss merged commit 7957364 into GoogleCloudPlatform:master Jan 3, 2018
@noerog noerog deleted the patch-3 branch January 4, 2018 21:59
NimJay pushed a commit that referenced this pull request Nov 19, 2022
NimJay pushed a commit that referenced this pull request Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants