-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add region tags to JWT refresh. #544
Conversation
Codecov Report
@@ Coverage Diff @@
## master #544 +/- ##
=======================================
Coverage 97.16% 97.16%
=======================================
Files 13 13
Lines 458 458
=======================================
Hits 445 445
Misses 13 13 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, make sure the changes from:
don't conflict, also may be conflicts with
https://github.com/GoogleCloudPlatform/nodejs-docs-samples/tree/tswast-patch-1
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
@googlebot I signed it! Checks should be green, both ben and I have signed, merging. |
🤖 I have created a release \*beep\* \*boop\* --- ## [3.3.0](https://www.github.com/googleapis/nodejs-text-to-speech/compare/v3.2.7...v3.3.0) (2021-08-23) ### Features * turns on self-signed JWT feature flag ([#543](https://www.github.com/googleapis/nodejs-text-to-speech/issues/543)) ([bd5ecd3](https://www.github.com/googleapis/nodejs-text-to-speech/commit/bd5ecd31f2cf39486b85c62e1f5d35850cde22b9)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release \*beep\* \*boop\* --- ## [3.1.0](https://www.github.com/googleapis/nodejs-dataproc/compare/v3.0.0...v3.1.0) (2021-10-13) ### Features * add Dataproc Serverless for Spark Batches API ([#543](https://www.github.com/googleapis/nodejs-dataproc/issues/543)) ([012b56f](https://www.github.com/googleapis/nodejs-dataproc/commit/012b56fd656b22fe555c9edafbfb9a8f20c91358)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
🤖 I have created a release \*beep\* \*boop\* --- ## [3.1.0](https://www.github.com/googleapis/nodejs-dataproc/compare/v3.0.0...v3.1.0) (2021-10-13) ### Features * add Dataproc Serverless for Spark Batches API ([#543](https://www.github.com/googleapis/nodejs-dataproc/issues/543)) ([012b56f](https://www.github.com/googleapis/nodejs-dataproc/commit/012b56fd656b22fe555c9edafbfb9a8f20c91358)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
No description provided.