Add requester pays samples #453
Merged
+340
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 11, 2017 20:07
Codecov Report
@@ Coverage Diff @@
## master #453 +/- ##
=======================================
Coverage 83.84% 83.84%
=======================================
Files 4 4
Lines 421 421
=======================================
Hits 353 353
Misses 68 68Continue to review full report at Codecov.
|
jmdobry
approved these changes
Aug 15, 2017
|
Done - FYI, I wasn't sure whether or not this sample warranted a |
frankyn
reviewed
Aug 15, 2017
storage/README.md
Outdated
| Examples: | ||
| node requesterPays.js enable my-bucket Enables requester-pays requests on a bucket named | ||
| "my-bucket". | ||
| node requesterPays.js list Disables requester-pays requests on a bucket named |
There was a problem hiding this comment.
Should this be disable? I think the README didn't generate correctly.
There was a problem hiding this comment.
Fixed 😄 - good catch!
frankyn
requested changes
Aug 15, 2017
| let status; | ||
| const metadata = data[0]; | ||
| if (metadata && metadata.billing && metadata.billing.requesterPays) { | ||
| status = `enabled`; |
There was a problem hiding this comment.
Should this string use single-quotes?
There was a problem hiding this comment.
Technically, the other strings should use backticks. Will fix.
added 2 commits
August 15, 2017 16:00
frankyn
reviewed
Aug 15, 2017
storage/requesterPays.js
Outdated
| @@ -177,8 +177,8 @@ const cli = require(`yargs`) | |||
| (opts) => downloadFileUsingRequesterPays(opts.projectId, opts.bucketName, opts.srcFileName, opts.destFileName) | |||
| ) | |||
| .example(`node $0 enable my-bucket`, `Enables requester-pays requests on a bucket named "my-bucket".`) | |||
| .example(`node $0 list`, `Disables requester-pays requests on a bucket named "my-bucket".`) | |||
| .example(`node $0 delete my-bucket`, `Determines whether requester-pays requests are enabled for a bucket named "my-bucket".`) | |||
| .example(`node $0 disable`, `Disables requester-pays requests on a bucket named "my-bucket".`) | |||
There was a problem hiding this comment.
One last nit, disable should accept a bucket id similar to enable.
ace-n
pushed a commit
that referenced
this pull request
Nov 14, 2022
* chore(main): release 3.0.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
ace-n
pushed a commit
that referenced
this pull request
Nov 14, 2022
* chore(main): release 3.0.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
ace-n
pushed a commit
that referenced
this pull request
Nov 14, 2022
* chore(main): release 3.0.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
ace-n
pushed a commit
that referenced
this pull request
Nov 15, 2022
* chore(main): release 3.0.0 * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.