Add Cloud Functions template render sample. #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ace-n Looks good to you? |
jmdobry
force-pushed
the
functions-template
branch
from
478daa7 to
b08f979
Compare
Codecov Report
@@ Coverage Diff @@
## master #365 +/- ##
=======================================
Coverage 83.88% 83.88%
=======================================
Files 4 4
Lines 422 422
=======================================
Hits 354 354
Misses 68 68Continue to review full report at Codecov.
|
ace-n
approved these changes
May 1, 2017
| // [START functions_helloworld_template] | ||
| const pug = require('pug'); | ||
|
|
||
| // Renders the index.pug |
functions/helloworld/package.json
Outdated
| "safe-buffer": "5.0.1" | ||
| }, | ||
| "devDependencies": { | ||
| "@google-cloud/nodejs-repo-tools": "1.3.1", | ||
| "@google-cloud/nodejs-repo-tools": "1.3.2", |
There was a problem hiding this comment.
FYI: you'll need to revert this change. (It will cause a merge conflict with #370.)
jmdobry
force-pushed
the
functions-template
branch
from
b08f979 to
2d4a046
Compare
This was referenced Feb 1, 2020
This was referenced Dec 24, 2020
Open
This was referenced Apr 12, 2022
This was referenced Apr 15, 2022
telpirion
pushed a commit
that referenced
this pull request
Nov 9, 2022
🤖 I have created a release \*beep\* \*boop\* --- ## [3.5.0](https://www.github.com/googleapis/nodejs-talent/compare/v3.4.1...v3.5.0) (2021-09-15) ### Features * Added a new `KeywordMatchMode` field to support more keyword matching options feat: Added more `DiversificationLevel` configuration options ([#365](https://www.github.com/googleapis/nodejs-talent/issues/365)) ([bc2c5cf](https://www.github.com/googleapis/nodejs-talent/commit/bc2c5cfc7dd465dd476c027acd978e07ed18b298)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
telpirion
pushed a commit
that referenced
this pull request
Nov 9, 2022
🤖 I have created a release \*beep\* \*boop\* --- ## [3.5.0](https://www.github.com/googleapis/nodejs-talent/compare/v3.4.1...v3.5.0) (2021-09-15) ### Features * Added a new `KeywordMatchMode` field to support more keyword matching options feat: Added more `DiversificationLevel` configuration options ([#365](https://www.github.com/googleapis/nodejs-talent/issues/365)) ([bc2c5cf](https://www.github.com/googleapis/nodejs-talent/commit/bc2c5cfc7dd465dd476c027acd978e07ed18b298)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
ace-n
pushed a commit
that referenced
this pull request
Nov 11, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 11, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 14, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 15, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 15, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
ahrarmonsur
pushed a commit
that referenced
this pull request
Nov 17, 2022
pattishin
pushed a commit
that referenced
this pull request
Nov 18, 2022
🤖 I have created a release *beep* *boop* --- ## [2.3.0](googleapis/nodejs-ai-platform@v2.2.0...v2.3.0) (2022-09-21) ### Features * Add deleteFeatureValues in aiplatform v1beta1 featurestore_service.proto ([#371](googleapis/nodejs-ai-platform#371)) ([e1c5cd6](googleapis/nodejs-ai-platform@e1c5cd6)) * Add timestamp_outside_retention_rows_count, RemoveContextChildren, order_by, InputArtifact, read_mask, TransferLearningConfig ([#450](googleapis/nodejs-ai-platform#450)) ([3a3f71f](googleapis/nodejs-ai-platform@3a3f71f)) ### Bug Fixes * Allow passing gax instance to client constructor ([#365](googleapis/nodejs-ai-platform#365)) ([6200e38](googleapis/nodejs-ai-platform@6200e38)) * Preserve default values in x-goog-request-params header ([#370](googleapis/nodejs-ai-platform#370)) ([6860cfd](googleapis/nodejs-ai-platform@6860cfd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
NimJay
pushed a commit
that referenced
this pull request
Nov 18, 2022
NimJay
pushed a commit
that referenced
this pull request
Nov 18, 2022
pattishin
pushed a commit
that referenced
this pull request
Nov 22, 2022
🤖 I have created a release *beep* *boop* --- ## [2.3.0](googleapis/nodejs-ai-platform@v2.2.0...v2.3.0) (2022-09-21) ### Features * Add deleteFeatureValues in aiplatform v1beta1 featurestore_service.proto ([#371](googleapis/nodejs-ai-platform#371)) ([e1c5cd6](googleapis/nodejs-ai-platform@e1c5cd6)) * Add timestamp_outside_retention_rows_count, RemoveContextChildren, order_by, InputArtifact, read_mask, TransferLearningConfig ([#450](googleapis/nodejs-ai-platform#450)) ([3a3f71f](googleapis/nodejs-ai-platform@3a3f71f)) ### Bug Fixes * Allow passing gax instance to client constructor ([#365](googleapis/nodejs-ai-platform#365)) ([6200e38](googleapis/nodejs-ai-platform@6200e38)) * Preserve default values in x-goog-request-params header ([#370](googleapis/nodejs-ai-platform#370)) ([6860cfd](googleapis/nodejs-ai-platform@6860cfd)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.