Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples(talent): migrate code from googleapis/nodejs-talent #2813

Closed
wants to merge 4 commits into from
Closed

samples(talent): migrate code from googleapis/nodejs-talent #2813

wants to merge 4 commits into from

Conversation

telpirion
Copy link
Contributor

@telpirion telpirion commented Nov 9, 2022 •
edited
Loading

saumyasahu-bot and others added 3 commits October 14, 2020 16:52
@saumyasahu-bot
samples: add Job Search v4 samples (#255)
2856596
@SurferJeffAtGoogle
fix: flaky sample test two ways (#375)
bf90504 
1. Examine all the resources in the response.
2. I suspect, but cannot prove that the search function is eventually
   consistent.  So, give it some time.

Fixes googleapis/nodejs-talent#344
@telpirion
Merge remote-tracking branch 'migration/main' into nodejs-talent-migr…
ec0d01f 
…ation
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Nov 9, 2022
@telpirion telpirion changed the title migrate code from googleapis/nodejs-talent samples(talent): migrate code from googleapis/nodejs-talent Nov 9, 2022
@telpirion telpirion marked this pull request as ready for review November 9, 2022 18:08
@telpirion telpirion requested a review from a team as a code owner November 9, 2022 18:08
@snippet-bot
Copy link

snippet-bot bot commented Nov 9, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 19 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

grayside
grayside requested changes Nov 9, 2022
View reviewed changes
Copy link
Collaborator

@grayside grayside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing: package.json
Missing: test integration, but possibly there are no tests?

@kweinmeister
Copy link
Collaborator

kweinmeister commented Nov 9, 2022 •
edited
Loading

+1, we should include tests and the test workflow (see: https://github.com/googleapis/nodejs-talent/blob/main/samples/test/talent.test.js)

@telpirion
Copy link
Contributor Author

It looks like the tests are just that one test file. I'll add it into this PR.

@telpirion
Copy link
Contributor Author

Nevermind. I'm going to close this PR and start over.

@telpirion telpirion closed this Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grayside grayside grayside requested changes

Assignees
No one assigned
Labels
samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@telpirion @kweinmeister @grayside @saumyasahu-bot @SurferJeffAtGoogle