Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(functions/v2): add GCE + CAL sample #2401

Merged
merged 3 commits into from
Nov 2, 2021
Merged

feat(functions/v2): add GCE + CAL sample #2401

merged 3 commits into from
Nov 2, 2021

Conversation

ace-n
Copy link
Contributor

@ace-n ace-n commented Nov 2, 2021

Notes:

  1. This sample has an E2E test only. This is currently disabled, as I don't think the testing project is configured for V2. (We should enable it once GCF V2 is available within that project, provided we're OK with a non-GA platform being tested.)
  2. This uses an alpha version of the GCE Client Library. We'll need to replace that once the library goes GA.

@ace-n ace-n requested a review from a team as a code owner November 2, 2021 02:13
@snippet-bot
Copy link

snippet-bot bot commented Nov 2, 2021 •
edited
Loading

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 2, 2021
@product-auto-label product-auto-label bot added api: cloudfunctions Issues related to the Cloud Run functions API. samples Issues that are directly related to samples. labels Nov 2, 2021
JustinBeckwith
JustinBeckwith approved these changes Nov 2, 2021
View reviewed changes
functions/v2/index.js Show resolved Hide resolved
@ace-n ace-n added the automerge Merge the pull request once unit tests and other checks pass. label Nov 2, 2021
@gcf-merge-on-green gcf-merge-on-green bot merged commit 550cabf into main Nov 2, 2021
@gcf-merge-on-green gcf-merge-on-green bot deleted the gce-cal branch November 2, 2021 18:28
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 2, 2021
noerog pushed a commit that referenced this pull request Sep 2, 2022
@noerog
feat(functions/v2): add GCE + CAL sample (#2401)
e096b9c 
Notes:
1. This sample has an E2E test _only_. This is currently disabled, as I don't think the testing project is configured for V2. (We should enable it once GCF V2 is available within that project, **provided** we're OK with a non-GA platform being tested.)
2. This uses an alpha version of the GCE Client Library. We'll need to replace that once the library goes GA.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

Assignees
No one assigned
Labels
api: cloudfunctions Issues related to the Cloud Run functions API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ace-n @JustinBeckwith