Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: delete samples for talent API #2104

Merged
merged 4 commits into from
Dec 10, 2020
Merged

chore: delete samples for talent API #2104

merged 4 commits into from
Dec 10, 2020

Conversation

fhinkel
Copy link
Contributor

@fhinkel fhinkel commented Dec 8, 2020 •
edited
Loading

Samples have moved to
https://github.com/googleapis/nodejs-talent/tree/master/samples/snippet

Fixes: #1803
Fixes: #2103

I couldn't find any uses of these samples in our docs.

@fhinkel fhinkel requested a review from happyhuman as a code owner December 8, 2020 21:40
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 8, 2020
@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Dec 8, 2020
@snippet-bot
Copy link

snippet-bot bot commented Dec 8, 2020 •
edited
Loading

Here is the summary of possible violations 😱

There are 19 possible violations for removing region tag in use.

Here is the summary of changes.

You deleted 76 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

JustinBeckwith
JustinBeckwith suggested changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flagging this until the snippet bot warning is checked out

@fhinkel fhinkel added the type: docs Improvement to the documentation for an API. label Dec 9, 2020
@fhinkel
Copy link
Contributor Author

fhinkel commented Dec 9, 2020 •
edited
Loading

Working on updating the use of the snippets, internally: cl/346483900. Will come back to this once the CL lands.

@tmatsuo
Copy link
Contributor

tmatsuo commented Dec 9, 2020

@fhinkel

When the internal CL lands, the drift database will be updated. Then their cron job will dump the json file for snippet-bot shortly (I think they run it every 5 minutes or so).

After that point, you can check the Refresh this comment checkbox for refreshing the comment from snippet-bot.

Let me know if the bot still warns.

@tmatsuo
Copy link
Contributor

tmatsuo commented Dec 9, 2020

@fhinkel It looks like the internal CL landed, so I'm going to check the refresh checkbox.

@tmatsuo
Copy link
Contributor

tmatsuo commented Dec 9, 2020

@fhinkel The number went down from 20 to 18.

I think we need to publish the devsite docs for actually updating the database and the published web page.

@fhinkel
Copy link
Contributor Author

fhinkel commented Dec 9, 2020 •
edited
Loading

@tmatsuo Thanks. Let me run another refresh. The devsite docs are published, see e.g. https://cloud.google.com/talent-solution/job-search/docs/samples/job-search-histogram-search

@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 9, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 9, 2020
@tmatsuo
Copy link
Contributor

tmatsuo commented Dec 9, 2020

@fhinkel It seems like the drift team's data pipeline is delayed. Internal reference b/175210192

Other than that, many devsite pages are still referring to nodejs-docs-samples.

@fhinkel
Copy link
Contributor Author

fhinkel commented Dec 10, 2020

I'm wondering if we run into problems because the majority of the reported pages are generated by sample-browser.

@fhinkel
Copy link
Contributor Author

fhinkel commented Dec 10, 2020

@JustinBeckwith The bot found a few legitimate issues and I updated those. The remaining issues are the usages that sample-browser generates. They'll disappear when the samples get deleted. @tmatsuo will make that change to the bot, but for now we should ignore the warning.

JustinBeckwith
JustinBeckwith approved these changes Dec 10, 2020
View reviewed changes
Copy link
Contributor

@JustinBeckwith JustinBeckwith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just please check in with @tmatsuo that he doesn't need this to verify fixes from DRIFT :)

@fhinkel fhinkel merged commit 3399c95 into master Dec 10, 2020
@fhinkel fhinkel deleted the fhinkel-remove-talent branch December 10, 2020 20:37
@snyk-bot snyk-bot mentioned this pull request Mar 11, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JustinBeckwith JustinBeckwith JustinBeckwith approved these changes

@happyhuman happyhuman Awaiting requested review from happyhuman

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples. type: docs Improvement to the documentation for an API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Talent samples should live in googleapis/nodejs-talent job/v4 lacks tests
4 participants
@fhinkel @tmatsuo @JustinBeckwith @kokoro-team