Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete no-warning-comments eslint rule #2044

Merged
merged 3 commits into from
Nov 5, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions datacatalog/cloud-client/createEntryGroup.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
/* eslint-disable no-warning-comments */

// Copyright 2019 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
Expand Down
2 changes: 0 additions & 2 deletions datacatalog/cloud-client/createFilesetEntry.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
/* eslint-disable no-warning-comments */

// Copyright 2019 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
Expand Down
2 changes: 0 additions & 2 deletions datacatalog/cloud-client/lookupEntry.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
/* eslint-disable no-warning-comments */

// Copyright 2019 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
Expand Down
2 changes: 0 additions & 2 deletions datacatalog/quickstart/createFilesetEntry.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
/* eslint-disable no-warning-comments */

// Copyright 2019 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
Expand Down
2 changes: 0 additions & 2 deletions datacatalog/quickstart/deleteFilesetEntry.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
/* eslint-disable no-warning-comments */

// Copyright 2019 Google LLC
//
// Licensed under the Apache License, Version 2.0 (the "License");
Expand Down
4 changes: 0 additions & 4 deletions datastore/functions/test/.eslintrc.yml

This file was deleted.

2 changes: 0 additions & 2 deletions functions/billing/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

/* eslint-disable no-warning-comments */

// [START functions_billing_limit]
// [START functions_billing_stop]
const {google} = require('googleapis');
Expand Down
1 change: 0 additions & 1 deletion functions/helloworld/.eslintrc.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
---
rules:
no-warning-comments: off
no-unused-vars: off

4 changes: 0 additions & 4 deletions functions/http/.eslintrc.yml

This file was deleted.

8 changes: 6 additions & 2 deletions functions/http/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,9 @@ exports.uploadFile = (req, res) => {

// This code will process each non-file field in the form.
busboy.on('field', (fieldname, val) => {
// TODO(developer): Process submitted field values here
/**
* TODO(developer): Process submitted field values here
*/
console.log(`Processed field ${fieldname}: ${val}.`);
fields[fieldname] = val;
});
Expand Down Expand Up @@ -172,7 +174,9 @@ exports.uploadFile = (req, res) => {
busboy.on('finish', async () => {
await Promise.all(fileWrites);

// TODO(developer): Process saved files here
/**
* TODO(developer): Process saved files here
*/
for (const file in uploads) {
fs.unlinkSync(uploads[file]);
}
Expand Down
2 changes: 0 additions & 2 deletions healthcare/datasets/createDataset.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

/* eslint-disable no-warning-comments */

'use strict';

const main = (
Expand Down
2 changes: 0 additions & 2 deletions healthcare/datasets/deidentifyDataset.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

/* eslint-disable no-warning-comments */

'use strict';

const main = (
Expand Down
2 changes: 0 additions & 2 deletions healthcare/datasets/deleteDataset.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

/* eslint-disable no-warning-comments */

'use strict';

const main = (
Expand Down
2 changes: 0 additions & 2 deletions healthcare/datasets/getDataset.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

/* eslint-disable no-warning-comments */

'use strict';

const main = (
Expand Down
2 changes: 0 additions & 2 deletions healthcare/datasets/getDatasetIamPolicy.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

/* eslint-disable no-warning-comments */

'use strict';

const main = (
Expand Down
2 changes: 0 additions & 2 deletions healthcare/datasets/listDatasets.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

/* eslint-disable no-warning-comments */

'use strict';

const main = (
Expand Down
2 changes: 0 additions & 2 deletions healthcare/datasets/patchDataset.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

/* eslint-disable no-warning-comments */

'use strict';

const main = (
Expand Down
2 changes: 0 additions & 2 deletions healthcare/datasets/setDatasetIamPolicy.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

/* eslint-disable no-warning-comments */

'use strict';

const main = (
Expand Down
2 changes: 0 additions & 2 deletions healthcare/dicom/createDicomStore.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

/* eslint-disable no-warning-comments */

'use strict';

const main = (
Expand Down
2 changes: 0 additions & 2 deletions healthcare/dicom/deleteDicomStore.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

/* eslint-disable no-warning-comments */

'use strict';

const main = (
Expand Down
2 changes: 0 additions & 2 deletions healthcare/dicom/dicomWebDeleteStudy.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

/* eslint-disable no-warning-comments */

'use strict';

const main = (
Expand Down
2 changes: 0 additions & 2 deletions healthcare/dicom/dicomWebRetrieveInstance.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

/* eslint-disable no-warning-comments */

'use strict';

const main = (
Expand Down
2 changes: 0 additions & 2 deletions healthcare/dicom/dicomWebRetrieveRendered.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

/* eslint-disable no-warning-comments */

'use strict';

const main = (
Expand Down
2 changes: 0 additions & 2 deletions healthcare/dicom/dicomWebRetrieveStudy.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

/* eslint-disable no-warning-comments */

'use strict';

const main = (
Expand Down
2 changes: 0 additions & 2 deletions healthcare/dicom/dicomWebSearchForInstances.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

/* eslint-disable no-warning-comments */

'use strict';

const main = (
Expand Down
2 changes: 0 additions & 2 deletions healthcare/dicom/dicomWebSearchStudies.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

/* eslint-disable no-warning-comments */

'use strict';

const main = (
Expand Down
2 changes: 0 additions & 2 deletions healthcare/dicom/dicomWebStoreInstance.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

/* eslint-disable no-warning-comments */

'use strict';

const main = (
Expand Down
2 changes: 0 additions & 2 deletions healthcare/dicom/exportDicomInstanceGcs.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

/* eslint-disable no-warning-comments */

'use strict';

const main = (
Expand Down
2 changes: 0 additions & 2 deletions healthcare/dicom/getDicomStore.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

/* eslint-disable no-warning-comments */

'use strict';

const main = (
Expand Down
2 changes: 0 additions & 2 deletions healthcare/dicom/getDicomStoreIamPolicy.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

/* eslint-disable no-warning-comments */

'use strict';

const main = (
Expand Down
2 changes: 0 additions & 2 deletions healthcare/dicom/importDicomInstance.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

/* eslint-disable no-warning-comments */

'use strict';

const main = (
Expand Down
2 changes: 0 additions & 2 deletions healthcare/dicom/listDicomStores.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

/* eslint-disable no-warning-comments */

'use strict';

const main = (
Expand Down
2 changes: 0 additions & 2 deletions healthcare/dicom/patchDicomStore.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

/* eslint-disable no-warning-comments */

'use strict';

const main = (
Expand Down
2 changes: 0 additions & 2 deletions healthcare/dicom/setDicomStoreIamPolicy.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

/* eslint-disable no-warning-comments */

'use strict';

const main = (
Expand Down
2 changes: 0 additions & 2 deletions healthcare/fhir/createFhirStore.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

/* eslint-disable no-warning-comments */

'use strict';

const main = (
Expand Down
2 changes: 0 additions & 2 deletions healthcare/fhir/deleteFhirResource.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

/* eslint-disable no-warning-comments */

'use strict';

const main = (
Expand Down
2 changes: 0 additions & 2 deletions healthcare/fhir/deleteFhirResourcePurge.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

/* eslint-disable no-warning-comments */

'use strict';

const main = (
Expand Down
2 changes: 0 additions & 2 deletions healthcare/fhir/deleteFhirStore.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

/* eslint-disable no-warning-comments */

'use strict';

const main = (
Expand Down
2 changes: 0 additions & 2 deletions healthcare/fhir/exportFhirResources.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

/* eslint-disable no-warning-comments */

'use strict';

const main = (
Expand Down
2 changes: 0 additions & 2 deletions healthcare/fhir/getFhirResource.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

/* eslint-disable no-warning-comments */

'use strict';

const main = (
Expand Down
2 changes: 0 additions & 2 deletions healthcare/fhir/getFhirResourceHistory.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

/* eslint-disable no-warning-comments */

'use strict';

const main = (
Expand Down
2 changes: 0 additions & 2 deletions healthcare/fhir/getFhirStore.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

/* eslint-disable no-warning-comments */

'use strict';

const main = (
Expand Down
2 changes: 0 additions & 2 deletions healthcare/fhir/getFhirStoreCapabilities.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

/* eslint-disable no-warning-comments */

'use strict';

const main = (
Expand Down
2 changes: 0 additions & 2 deletions healthcare/fhir/getFhirStoreIamPolicy.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

/* eslint-disable no-warning-comments */

'use strict';

const main = (
Expand Down
2 changes: 0 additions & 2 deletions healthcare/fhir/getPatientEverything.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,6 @@
// See the License for the specific language governing permissions and
// limitations under the License.

/* eslint-disable no-warning-comments */

'use strict';

const main = (
Expand Down
Loading