Switch to yargs. #189
Merged
Switch to yargs. #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -13,7 +13,7 @@ | |||
|
|
|||
| 'use strict'; | |||
|
|
|||
| var example = require('../query'); | |||
| var example = require('../queries'); | |||
There was a problem hiding this comment.
Not terribly worried about this change (because it needs to be done anyway), but this wasn't technically a yargs change. 😛
|
LGTM, other than the nits that I mentioned. (Also: a few PubSub tests are failing on circle - maybe some names need to be changed around?) |
| @@ -15,6 +15,7 @@ | |||
|
|
|||
| var proxyquire = require('proxyquire').noCallThru(); | |||
| var bucketName = 'foo'; | |||
There was a problem hiding this comment.
Nit: should this be srcBucketName?
|
@dpebot Merge when green. |
|
Okay! I'll merge when all statuses are green. |
dpebot
added
the
automerge
jmdobry
removed
the
automerge
Current coverage is 89.04% (diff: 96.05%)
|
ace-n
pushed a commit
that referenced
this pull request
Nov 11, 2022
include the required region if using EU based processor (defaults to US) Co-authored-by: Justin Beckwith <[email protected]>
ace-n
pushed a commit
that referenced
this pull request
Nov 11, 2022
include the required region if using EU based processor (defaults to US) Co-authored-by: Justin Beckwith <[email protected]>
ace-n
pushed a commit
that referenced
this pull request
Nov 12, 2022
include the required region if using EU based processor (defaults to US) Co-authored-by: Justin Beckwith <[email protected]>
ace-n
pushed a commit
that referenced
this pull request
Nov 14, 2022
include the required region if using EU based processor (defaults to US) Co-authored-by: Justin Beckwith <[email protected]>
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
ace-n
pushed a commit
that referenced
this pull request
Nov 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.