-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Create Data Catalog search sample #1799
feat: Create Data Catalog search sample #1799
Conversation
Hi @fhinkel Changed to [DO NOT MERGE]. Could you help providing the value for the environment variable - Organization ID for the test Project at: I didn't find any other samples using the Org ID. This sample contains a use case that needs to run with the Org ID. |
As far as I can tell we don't have an org set up. |
I will remove the org_id sample from this PR then, and keep just the sample that uses the project scope, I will try to find out internaly if there's a way to set up a test org id. |
Can you use the same project as this test? https://github.com/googleapis/nodejs-security-center/blob/e50061a5f834a356b0221ff01d8de4ed02089260/.kokoro/samples-test.sh#L24 |
Thanks! I will test it out. |
@fhinkel
|
ping @fhinkel |
Whitelisted those variables. |
Currently we have inline search samples at:
https://cloud.google.com/data-catalog/docs/how-to/search#data-catalog-how-to-search-nodejs
Sending this PR so tech writer can point the samples to the nodejs-docs-samples github.
Need help at setting an environment variable with the test project Org ID at:
.kokoro/datacatalog.cfg
Could one of the reviewers provide the org id?