-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing await for an async function call #1753
fix: add missing await for an async function call #1753
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Maybe the better solution here is to not return anything from cc @fhinkel |
@ace-n I could change it to something like this. Let me know If I understand your question correctly. diff --git a/functions/imagemagick/index.js b/functions/imagemagick/index.js
index 730ed3ef..44cd4f5a 100644
--- a/functions/imagemagick/index.js
+++ b/functions/imagemagick/index.js
@@ -49,7 +49,7 @@ exports.blurOffensiveImages = async (event) => {
detections.violence === 'VERY_LIKELY'
) {
console.log(`Detected ${file.name} as inappropriate.`);
- return await blurImage(file, BLURRED_BUCKET_NAME);
+ await blurImage(file, BLURRED_BUCKET_NAME);
} else {
console.log(`Detected ${file.name} as OK.`);
}
@@ -102,6 +102,6 @@ const blurImage = async (file, blurredBucketName) => {
// Delete the temporary file.
const unlink = promisify(fs.unlink);
- return unlink(tempLocalPath);
+ unlink(tempLocalPath); // non-blocking execution
};
// [END functions_imagemagick_blur] |
No description provided.