Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): run/logging-manual test failures (#1637) #1680

Merged
merged 2 commits into from
Mar 31, 2020
Merged

fix(tests): run/logging-manual test failures (#1637) #1680

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcc807e
fix(tests): run/logging-manual test failures (#1637)
grayside Mar 30, 2020
e5b4e20
Merge branch 'master' into run/logging-manual-got
fhinkel Mar 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions run/logging-manual/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ For more details on how to work with this sample read the [Google Cloud Run Node

### `npm run e2e-test`

```
```sh
export SERVICE_NAME=logging-manual
export CONTAINER_IMAGE=gcr.io/${GOOGLE_CLOUD_PROJECT}/logging-manual
npm run e2e-test
Expand Down Expand Up @@ -69,4 +69,3 @@ test/runner.sh sleep 20
[compute metadata server](https://cloud.google.com/compute/docs/storing-retrieving-metadata)
and make system test HTTP requests. This is required in production for log correlation without
manually setting the $GOOGLE_CLOUD_PROJECT environment variable.

3 changes: 1 addition & 2 deletions run/logging-manual/test/system.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,8 @@ describe('Logging', () => {
if (!ID_TOKEN) {
throw Error('"ID_TOKEN" environment variable is required.');
}

await request('/', {
baseUrl: BASE_URL.trim(),
prefixUrl: BASE_URL.trim(),
headers: {
Authorization: `Bearer ${ID_TOKEN.trim()}`,
},
Expand Down