Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: include project in mocha xunit report #1665

Merged
merged 8 commits into from
Mar 30, 2020
Merged

feat: include project in mocha xunit report #1665

merged 8 commits into from
Mar 30, 2020

Conversation

fhinkel
Copy link
Contributor

@fhinkel fhinkel commented Mar 30, 2020

Issues filed by the build bot have a more descriptive title now, i.e., they list the subfolder rather than "Mocha test".

Use a .js config instead of yaml, so we can use ${PROJECT}.

@fhinkel fhinkel requested a review from gguuss as a code owner March 30, 2020 15:01
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Mar 30, 2020
@fhinkel fhinkel requested a review from tbpg March 30, 2020 15:01
@fhinkel fhinkel added do not merge Indicates a pull request not ready for merge, due to either quality or timing. kokoro:run Add this label to force Kokoro to re-run the tests. labels Mar 30, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 30, 2020
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 30, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 30, 2020
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 30, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 30, 2020
@fhinkel fhinkel changed the title DO NOT MERGE Add xunit to iot/http_example for debugging [DO NOT MERGE] Add xunit to iot/http_example for debugging Mar 30, 2020
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 30, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 30, 2020
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 30, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 30, 2020
@fhinkel fhinkel added the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 30, 2020
@kokoro-team kokoro-team removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 30, 2020
@fhinkel fhinkel changed the title [DO NOT MERGE] Add xunit to iot/http_example for debugging feat: include project in moch xunit report Mar 30, 2020
@fhinkel fhinkel removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Mar 30, 2020
@fhinkel fhinkel changed the title feat: include project in moch xunit report feat: include project in mocha xunit report Mar 30, 2020
const config = {};

if (process.env.MOCHA_THROW_DEPRECATION === 'false') {
delete config['throw-deprecation'];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like config is always empty at this point?

}
config['reporter-option'] = reporterOptions;

module.exports = config
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Newline.

@fhinkel fhinkel merged commit 40e3345 into master Mar 30, 2020
@fhinkel fhinkel deleted the xunit branch March 30, 2020 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants