Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: cloud run ga #1582

Merged
merged 3 commits into from
Jan 24, 2020
Merged

chore: cloud run ga #1582

merged 3 commits into from
Jan 24, 2020

Conversation

grant
Copy link
Contributor

@grant grant commented Jan 7, 2020

Promotes gcloud run command to ga by removing beta subcommand.

@grant grant requested a review from grayside January 7, 2020 11:17
@grant grant requested a review from kurtisvg as a code owner January 7, 2020 11:17
@grant grant self-assigned this Jan 7, 2020
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 7, 2020
kurtisvg
kurtisvg approved these changes Jan 7, 2020
View reviewed changes
Copy link
Contributor

@kurtisvg kurtisvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for /cloud-sql

@grant grant added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 22, 2020
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 22, 2020
@grant
Copy link
Contributor Author

grant commented Jan 22, 2020

Failures are unrelated to the PR changes.

@grant
Copy link
Contributor Author

grant commented Jan 24, 2020

Ping @grayside for review.

@grayside
Copy link
Collaborator

Thanks for the ping Grant. I'll see if I can dig into the flaky tests today, they aren't merge blocking.

@grant grant merged commit 82e75e0 into master Jan 24, 2020
@grant grant deleted the grant_cloud_run_ga branch January 24, 2020 16:24
@dlminvestments dlminvestments mentioned this pull request May 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurtisvg kurtisvg kurtisvg approved these changes

@grayside grayside grayside approved these changes

@fhinkel fhinkel fhinkel approved these changes

Assignees

@grant grant

Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@grant @grayside @fhinkel @kurtisvg @googlebot @kokoro-team