Cloud client library migration part 2: Device creation / deletion #1566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
/FYI It looks like the failing tests are outside of my change. |
fhinkel
reviewed
Dec 16, 2019
fhinkel
reviewed
Dec 16, 2019
fhinkel
approved these changes
Dec 16, 2019
There was a problem hiding this comment.
LGTM - but, this should really live in the samples folder of @google-cloud/iot. This way we catch bugs with the sample tests, when the library is released instead of waiting until we update the dependency in this repo. Happy to merge this if that makes it easier for you to then transfer to the other repo.
|
@fhinkel I was going to finish migrating off of the Apiary client before moving to the separate repo. |
…udplatform/nodejs-docs-samples into iot-cloud-client-part2
…udplatform/nodejs-docs-samples into iot-cloud-client-part2
|
Merging, after I have completed the migration we'll move this to the Cloud client library repo to simplify testing and releasing. |
|
I'm two PRs away from being ready to move to the Cloud client library repo. |
This was referenced Dec 23, 2020
This was referenced Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates the create / delete device snippets to Cloud Client library