Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve version tags in headless chrome sample #834

Closed
fhinkel opened this issue Nov 8, 2018 · 5 comments · Fixed by #1356
Closed

Improve version tags in headless chrome sample #834

fhinkel opened this issue Nov 8, 2018 · 5 comments · Fixed by #1356

Comments

@fhinkel
Copy link
Contributor

fhinkel commented Nov 8, 2018

@steren can you fix this?

Per our guidelines:

Region tag should use a product prefix, e.g. "vision_".

Where does the code snippet show up in our docs? Our tool can't find it.

Update region tag and link to a new or existing tracked sample.
Import into Devsite or delete.

@fhinkel
Copy link
Contributor Author

fhinkel commented Nov 15, 2018

ping @steren

@steren
Copy link
Contributor

steren commented Nov 20, 2018

I will not have time for it, and this needs to be synced with docs changes. Please follow up with @llatif

@fhinkel
Copy link
Contributor Author

fhinkel commented Feb 28, 2019

@llatif Can you please update the region tags for the headless chrome sample to follow our guidelines. Thanks.

@fhinkel
Copy link
Contributor Author

fhinkel commented Mar 22, 2019

ping @llatif

@grant
Copy link
Contributor

grant commented Jun 11, 2019

See above PR.

grant added a commit that referenced this issue Jun 11, 2019
* fix: Fixes GAE headless chrome region tags. See #834

* Update app.js
grayside pushed a commit that referenced this issue Nov 11, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
ace-n pushed a commit that referenced this issue Nov 12, 2022
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants