You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are some unused functions in run/idp-sql.
Some are not covered by region tags so we should be able to delete them. Those inside region tags should have test coverage and thus not show up as unused.
$ npm run lint
nodejs-docs-samples/run/idp-sql/static/config.js
2:7 warning 'config' is assigned a value but never used no-unused-vars
nodejs-docs-samples/run/idp-sql/static/firebase.js
22:10 warning 'signIn' is defined but never used no-unused-vars
40:16 warning 'vote' is defined but never used no-unused-vars
The text was updated successfully, but these errors were encountered:
We can opt out (which we're doing right now with .eslintrc in the run/idp-sql folder. Thanks for clarifying, I didn't realize they're used in fronttend code. Ideally, we would have tests for those functions, but then we'd need a bundler and it would probably convolute the sample too much.
There are some unused functions in
run/idp-sql
.Some are not covered by region tags so we should be able to delete them. Those inside region tags should have test coverage and thus not show up as unused.
The text was updated successfully, but these errors were encountered: