Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn on + fix GTS lint rules #2030

Closed
ace-n opened this issue Oct 28, 2020 · 0 comments · Fixed by #2045
Closed

Turn on + fix GTS lint rules #2030

ace-n opened this issue Oct 28, 2020 · 0 comments · Fixed by #2045
Assignees
@fhinkel
Labels
samples Issues that are directly related to samples. type: cleanup An internal cleanup or hygiene concern.

Comments

@ace-n
Copy link
Contributor

ace-n commented Oct 28, 2020

This issue is tracking a TODO from #2025:

Disable a bunch of rules to get this to pass. We'll need to turn them on and fix their usages manually.
@ace-n ace-n added type: cleanup An internal cleanup or hygiene concern. samples Issues that are directly related to samples. labels Oct 28, 2020
This was referenced Oct 30, 2020
Merged
Merged
Merged
Merged
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Nov 5, 2020
@fhinkel
chore: delete no-warning-comments eslint rule (#2044)
c026ae7 
See #2030
gcf-merge-on-green bot pushed a commit that referenced this issue Nov 5, 2020
@fhinkel
chore: turn on linting for run/idp-sql (#2045)
fe6cfb0 
Fixes #2030
@dlminvestments dlminvestments mentioned this issue Jun 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fhinkel fhinkel

Labels
samples Issues that are directly related to samples. type: cleanup An internal cleanup or hygiene concern.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: turn on linting for run/idp-sql GoogleCloudPlatform/nodejs-docs-samples
2 participants
@fhinkel @ace-n