Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run/markdown-preview/editor: Can successfully make a request to the Renderer failed #1878

Closed
flaky-bot bot opened this issue Jun 15, 2020 · 3 comments
Closed
Assignees
Labels
api: run Issues related to the Cloud Run API. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Jun 15, 2020

This test failed!

To configure my behavior, see the Build Cop Bot documentation.

If I'm commenting on this issue too often, add the buildcop: quiet label and
I will stop commenting.


commit: 27df832
buildURL: Build Status, Sponge
status: failed

Test output
Response code 500 (Internal Server Error)
HTTPError: Response code 500 (Internal Server Error)
    at EventEmitter.emitter.on (node_modules/got/dist/source/as-promise.js:118:31)
    at process._tickCallback (internal/process/next_tick.js:68:7)
@flaky-bot flaky-bot bot added buildcop: issue priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jun 15, 2020
@fhinkel fhinkel added api: run Issues related to the Cloud Run API. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Jun 15, 2020
@grayside
Copy link
Collaborator

@kelsk could you take a look?

@kelsk
Copy link
Contributor

kelsk commented Jun 16, 2020

@grayside it might be that the editor is making a request to the renderer before the renderer service has finished starting up. I've added a retry to the http requests and made a new PR

@yoshi-automation yoshi-automation added the triage me I really want to be triaged. label Jun 16, 2020
@flaky-bot
Copy link
Author

flaky-bot bot commented Jun 16, 2020

Closing as a duplicate of #1877

@flaky-bot flaky-bot bot closed this as completed Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: run Issues related to the Cloud Run API. triage me I really want to be triaged. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

4 participants