Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run/markdown-preview/editor: Can successfully make a request to the Renderer failed #1877

Closed
flaky-bot bot opened this issue Jun 15, 2020 · 7 comments · Fixed by #1921
Closed

run/markdown-preview/editor: Can successfully make a request to the Renderer failed #1877

flaky-bot bot opened this issue Jun 15, 2020 · 7 comments · Fixed by #1921
Assignees
Labels
api: run Issues related to the Cloud Run API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Jun 15, 2020

This test failed!

To configure my behavior, see the Build Cop Bot documentation.

If I'm commenting on this issue too often, add the buildcop: quiet label and
I will stop commenting.


commit: 27df832
buildURL: Build Status, Sponge
status: failed

Test output
Response code 500 (Internal Server Error)
HTTPError: Response code 500 (Internal Server Error)
    at EventEmitter.emitter.on (node_modules/got/dist/source/as-promise.js:118:31)
    at process._tickCallback (internal/process/next_tick.js:68:7)
@flaky-bot flaky-bot bot added buildcop: issue priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jun 15, 2020
@fhinkel fhinkel added api: run Issues related to the Cloud Run API. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Jun 15, 2020
@grayside
Copy link
Collaborator

@kelsk could you take a look?

@flaky-bot
Copy link
Author

flaky-bot bot commented Jun 16, 2020

Test passed for commit fdf80fd (Build Status, Sponge)! Closing this issue.

@flaky-bot flaky-bot bot closed this as completed Jun 16, 2020
@flaky-bot flaky-bot bot reopened this Jun 18, 2020
@flaky-bot flaky-bot bot added buildcop: flaky priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Jun 18, 2020
@flaky-bot
Copy link
Author

flaky-bot bot commented Jun 18, 2020

Looks like this issue is flaky. 😟

I'm going to leave this open and stop commenting.

A human should fix and close this.


commit: e979fb8
buildURL: Build Status, Sponge
status: failed

Test output
`input` must not start with a slash when using `prefixUrl`
Error: `input` must not start with a slash when using `prefixUrl`
    at normalizeArguments (node_modules/got/dist/source/core/index.js:402:23)
    at normalizeArguments (node_modules/got/dist/source/as-promise/core.js:34:31)
    at got (node_modules/got/dist/source/create.js:88:39)
    at Context.it (test/system.test.js:57:30)

@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label Jun 18, 2020
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Jun 22, 2020
@averikitsch
Copy link
Contributor

@kelsk PTAL. Maybe up the retry limit.

@kelsk
Copy link
Contributor

kelsk commented Jun 23, 2020

@averikitsch I think I fixed this by changing the 'got' request format, in this PR from Friday - I removed the "/" from the endpoints so that it's properly formatted to use with the prefixUrl parameter

@averikitsch
Copy link
Contributor

The test may still be flaky (https://fusion.corp.google.com/projectanalysis/summary/KOKORO/prod:cloud-devrel%2Fnodejs-docs-samples%2Frelease%2Frun%2Fmarkdown-preview-editor). I'll close this issue and it will reopen if it finds it flaky.

@flaky-bot flaky-bot bot reopened this Jul 2, 2020
@flaky-bot
Copy link
Author

flaky-bot bot commented Jul 2, 2020

Oops! Looks like this issue is still flaky. It failed again. 😬

I reopened the issue, but a human will need to close it again.


commit: 858059c
buildURL: Build Status, Sponge
status: failed

Test output
Response code 500 (Internal Server Error)
HTTPError: Response code 500 (Internal Server Error)
    at onResponse (node_modules/got/dist/source/as-promise/index.js:124:28)
    at process._tickCallback (internal/process/next_tick.js:68:7)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: run Issues related to the Cloud Run API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. 🚨 This issue needs some love. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants