Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mocha Tests: can be reached by an HTTP request failed #1637

Closed
flaky-bot bot opened this issue Mar 26, 2020 · 2 comments · Fixed by #1680
Closed

Mocha Tests: can be reached by an HTTP request failed #1637

flaky-bot bot opened this issue Mar 26, 2020 · 2 comments · Fixed by #1680
Assignees
@grayside
Labels
api: run Issues related to the Cloud Run API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Mar 26, 2020

This test failed!

To configure my behavior, see the Build Cop Bot documentation.

If I'm commenting on this issue too often, add the buildcop: quiet label and
I will stop commenting.

commit: 91b5bb7
buildURL: Build Status, Sponge
status: failed
@fhinkel
Copy link
Contributor

fhinkel commented Mar 26, 2020

This is for run/logging-manual @grayside

@fhinkel fhinkel added api: run Issues related to the Cloud Run API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Mar 26, 2020
grayside added a commit that referenced this issue Mar 30, 2020
@grayside
fix(tests): run/logging-manual test failures (#1637)
dcc807e
@grayside
Copy link
Collaborator

#1557 broke the system tests for this sample.

@grayside grayside mentioned this issue Mar 30, 2020
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Mar 31, 2020
@grayside
fix(tests): run/logging-manual test failures (#1637) (#1680)
0822b53 
Fixes #1637

run/logging-manual tests started failing due to a compatibility break in upgrading to `got v10` #1557. This was not caught because the broken `got` feature is only used in system tests.
@dlminvestments dlminvestments mentioned this issue Jul 10, 2023
Open
@aqualen aqualen mentioned this issue Jul 11, 2023
Open
@pedroarapua pedroarapua mentioned this issue Jul 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grayside grayside

Labels
api: run Issues related to the Cloud Run API. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(tests): run/logging-manual test failures (#1637) GoogleCloudPlatform/nodejs-docs-samples
3 participants
@fhinkel @grayside @tbpg