Skip to content

Commit

Permalink
improving readability
Browse files Browse the repository at this point in the history
  • Loading branch information
Rafael Rodrigues committed Jun 5, 2024
1 parent 70a082d commit f805e8a
Show file tree
Hide file tree
Showing 16 changed files with 316 additions and 309 deletions.
261 changes: 136 additions & 125 deletions security-center/snippets/system-test/v2/findings.test.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -14,134 +14,145 @@
* limitations under the License.
*/

const { SecurityCenterClient } = require('@google-cloud/security-center').v2;
const { assert } = require('chai');
const { execSync } = require('child_process');
const exec = cmd => execSync(cmd, { encoding: 'utf8' });
const { describe, it, before } = require('mocha');
const {SecurityCenterClient} = require('@google-cloud/security-center').v2;
const {assert} = require('chai');
const {execSync} = require('child_process');
const exec = cmd => execSync(cmd, {encoding: 'utf8'});
const {describe, it, before} = require('mocha');
const uuid = require('uuid');

const organizationId = process.env['GCLOUD_ORGANIZATION'];
const location = 'global';

describe('Client with sources and findings V2', async () => {
let data;
before(async () => {
// Creates a new client.
const client = new SecurityCenterClient();

const [projectId] = await client.getProjectId();
const [source] = await client
.createSource({
source: {
displayName: 'Customized Display Name V2',
description: 'A new custom source that does X',
},
parent: client.organizationPath(organizationId),
})
.catch(error => console.error(error));

const sourceId = source.name.split('/')[3];
const parent = `organizations/${organizationId}/sources/${sourceId}/locations/${location}`;
const resourceName = `//cloudresourcemanager.googleapis.com/organizations/${organizationId}`;
const findingId = uuid.v4().replace(/-/g, '');

const eventTime = new Date();
const createFindingTemplate = {
parent: parent,
findingId: findingId,
finding: {
state: 'ACTIVE',
// Resource the finding is associated with. This is an
// example any resource identifier can be used.
resourceName: resourceName,
// A free-form category.
category: 'MEDIUM_RISK_ONE',
// The time associated with discovering the issue.
eventTime: {
seconds: Math.floor(eventTime.getTime() / 1000),
nanos: (eventTime.getTime() % 1000) * 1e6,
},
},
};

const [finding] = await client.createFinding(createFindingTemplate);
createFindingTemplate.findingId = 'untouchedFindingId';
createFindingTemplate.finding.category = 'XSS';
const [untouchedFinding] = await client
.createFinding(createFindingTemplate)
.catch(error => console.error(error));

data = {
orgId: organizationId,
sourceId: sourceId,
sourceName: source.name,
findingId: findingId,
projectId: projectId,
findingName: finding.name,
untouchedFindingName: untouchedFinding.name,
};
console.log('my data %j', data);
});

it('client can create source V2', () => {
const output = exec(`node v2/createSource.js ${data.orgId}`);
assert.match(output, new RegExp(data.orgId));
assert.match(output, /New Source created/);
assert.notMatch(output, /undefined/);
});

it('client can create a finding V2', () => {
const output = exec(`node v2/createFinding.js ${data.orgId} ${data.sourceId}`);
assert.match(output, new RegExp(data.sourceName));
assert.match(output, /New finding created/);
assert.notMatch(output, /undefined/);
});

it('client can list all findings V2', () => {
const output = exec(`node v2/listAllFindings.js ${data.orgId}`);
assert.match(output, new RegExp(data.findingName));
assert.match(output, new RegExp(data.untouchedFindingName));
assert.notMatch(output, /undefined/);
});

it('client can list only some findings V2', () => {
const output = exec(`node v2/listFilteredFindings.js ${data.orgId}`);
assert.match(output, new RegExp(data.findingName));
assert.notMatch(output, new RegExp(data.untouchedFindingName));
assert.notMatch(output, /undefined/);
});

it('client can mute a findings V2', () => {
const output = exec(`node v2/setMuteFinding.js ${data.orgId} ${data.sourceId} ${data.findingId}`);
assert.match(output, new RegExp('MUTED'));
assert.match(output, /Mute value for the finding/);
assert.notMatch(output, /undefined/);
});

it('client can un mute a findings V2', () => {
const output = exec(`node v2/setUnmuteFinding.js ${data.orgId} ${data.sourceId} ${data.findingId}`);
assert.match(output, new RegExp('UNMUTED'));
assert.match(output, /Unmute a finding/);
assert.notMatch(output, /undefined/);
});

it('client can group all findings V2', () => {
const output = exec(`node v2/groupFindings.js ${data.orgId} ${data.sourceId}`);
assert.isAtLeast(4, output.match(/\n/g).length + 1);
assert.notMatch(output, /undefined/);
});

it('client group filtered findings V2', () => {
const output = exec(`node v2/groupFindingsWithFilter.js ${data.orgId} ${data.sourceId}`);
assert.isAtLeast(4, output.match(/\n/g).length + 1);
assert.notMatch(output, /undefined/);
});

it('client can bulk a mute a findings V2', () => {
const output = exec(`node v2/bulkMuteFindings.js ${data.orgId} ${data.projectId}`);
assert.match(output, /Bulk mute findings completed successfully/);
assert.notMatch(output, /undefined/);
});

});
let data;
before(async () => {
// Creates a new client.
const client = new SecurityCenterClient();

const [projectId] = await client.getProjectId();
const [source] = await client
.createSource({
source: {
displayName: 'Customized Display Name V2',
description: 'A new custom source that does X',
},
parent: client.organizationPath(organizationId),
})
.catch(error => console.error(error));

const sourceId = source.name.split('/')[3];
const parent = `organizations/${organizationId}/sources/${sourceId}/locations/${location}`;
const resourceName = `//cloudresourcemanager.googleapis.com/organizations/${organizationId}`;
const findingId = uuid.v4().replace(/-/g, '');

const eventTime = new Date();
const createFindingTemplate = {
parent: parent,
findingId: findingId,
finding: {
state: 'ACTIVE',
// Resource the finding is associated with. This is an
// example any resource identifier can be used.
resourceName: resourceName,
// A free-form category.
category: 'MEDIUM_RISK_ONE',
// The time associated with discovering the issue.
eventTime: {
seconds: Math.floor(eventTime.getTime() / 1000),
nanos: (eventTime.getTime() % 1000) * 1e6,
},
},
};

const [finding] = await client.createFinding(createFindingTemplate);
createFindingTemplate.findingId = 'untouchedFindingId';
createFindingTemplate.finding.category = 'XSS';
const [untouchedFinding] = await client
.createFinding(createFindingTemplate)
.catch(error => console.error(error));

data = {
orgId: organizationId,
sourceId: sourceId,
sourceName: source.name,
findingId: findingId,
projectId: projectId,
findingName: finding.name,
untouchedFindingName: untouchedFinding.name,
};
console.log('my data %j', data);
});

it('client can create source V2', () => {
const output = exec(`node v2/createSource.js ${data.orgId}`);
assert.match(output, new RegExp(data.orgId));
assert.match(output, /New Source created/);
assert.notMatch(output, /undefined/);
});

it('client can create a finding V2', () => {
const output = exec(
`node v2/createFinding.js ${data.orgId} ${data.sourceId}`
);
assert.match(output, new RegExp(data.sourceName));
assert.match(output, /New finding created/);
assert.notMatch(output, /undefined/);
});

it('client can list all findings V2', () => {
const output = exec(`node v2/listAllFindings.js ${data.orgId}`);
assert.match(output, new RegExp(data.findingName));
assert.match(output, new RegExp(data.untouchedFindingName));
assert.notMatch(output, /undefined/);
});

it('client can list only some findings V2', () => {
const output = exec(`node v2/listFilteredFindings.js ${data.orgId}`);
assert.match(output, new RegExp(data.findingName));
assert.notMatch(output, new RegExp(data.untouchedFindingName));
assert.notMatch(output, /undefined/);
});

it('client can mute a findings V2', () => {
const output = exec(
`node v2/setMuteFinding.js ${data.orgId} ${data.sourceId} ${data.findingId}`
);
assert.match(output, new RegExp('MUTED'));
assert.match(output, /Mute value for the finding/);
assert.notMatch(output, /undefined/);
});

it('client can un mute a findings V2', () => {
const output = exec(
`node v2/setUnmuteFinding.js ${data.orgId} ${data.sourceId} ${data.findingId}`
);
assert.match(output, new RegExp('UNMUTED'));
assert.match(output, /Unmute a finding/);
assert.notMatch(output, /undefined/);
});

it('client can group all findings V2', () => {
const output = exec(
`node v2/groupFindings.js ${data.orgId} ${data.sourceId}`
);
assert.isAtLeast(4, output.match(/\n/g).length + 1);
assert.notMatch(output, /undefined/);
});

it('client group filtered findings V2', () => {
const output = exec(
`node v2/groupFindingsWithFilter.js ${data.orgId} ${data.sourceId}`
);
assert.isAtLeast(4, output.match(/\n/g).length + 1);
assert.notMatch(output, /undefined/);
});

it('client can bulk a mute a findings V2', () => {
const output = exec(
`node v2/bulkMuteFindings.js ${data.orgId} ${data.projectId}`
);
assert.match(output, /Bulk mute findings completed successfully/);
assert.notMatch(output, /undefined/);
});
});
Loading

0 comments on commit f805e8a

Please sign in to comment.