chore: active no-unused-vars eslint rule (#2037)

GoogleCloudPlatform · Oct 30, 2020 · 77b6874 · 77b6874
1 parent 6db5736
commit 77b6874
Show file tree

Hide file tree

Showing 7 changed files with 5 additions and 12 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -6,7 +6,6 @@
   "rules": {
     "node/no-missing-require": ["off"], 
     "node/no-unpublished-require": ["off"], 
-    "no-unused-vars": ["off"], 
     "node/no-deprecated-api": ["off"],
     "no-process-exit": ["off"]
   }

diff --git a/cloud-sql/sqlserver/mssql/server.js b/cloud-sql/sqlserver/mssql/server.js
@@ -124,7 +124,7 @@ app.use(async (req, res, next) => {
 });
 
 // Serve the index page, showing vote tallies.
-app.get('/', async (req, res, next) => {
+app.get('/', async (req, res) => {
   try {
     // Get the 5 most recent votes.
     const recentVotesQuery = pool
@@ -171,7 +171,7 @@ app.get('/', async (req, res, next) => {
 });
 
 // Handle incoming vote requests and inserting them into the database.
-app.post('/', async (req, res, next) => {
+app.post('/', async (req, res) => {
   const {team} = req.body;
   const timestamp = new Date();
 

diff --git a/functions/http/package.json b/functions/http/package.json
@@ -17,8 +17,7 @@
   "devDependencies": {
     "mocha": "^8.0.0",
     "proxyquire": "^2.1.0",
-    "sinon": "^9.0.0",
-    "uuid": "^8.0.0"
+    "sinon": "^9.0.0"
   },
   "dependencies": {
     "@google-cloud/storage": "^5.0.0",

diff --git a/functions/http/test/index.test.js b/functions/http/test/index.test.js
@@ -17,7 +17,6 @@
 const proxyquire = require('proxyquire').noCallThru();
 const sinon = require('sinon');
 const assert = require('assert');
-const uuid = require('uuid');
 
 const getSample = () => {
   const requestPromise = sinon

diff --git a/healthcare/datasets/system-test/datasets.test.js b/healthcare/datasets/system-test/datasets.test.js
@@ -14,7 +14,6 @@
 
 'use strict';
 
-const path = require('path');
 const assert = require('assert');
 const uuid = require('uuid');
 const {execSync} = require('child_process');

diff --git a/healthcare/fhir/patchFhirResource.js b/healthcare/fhir/patchFhirResource.js
@@ -51,9 +51,7 @@ function main(
       requestBody: patchOptions,
     };
 
-    const resource = await healthcare.projects.locations.datasets.fhirStores.fhir.patch(
-      request
-    );
+    await healthcare.projects.locations.datasets.fhirStores.fhir.patch(request);
     console.log(`Patched ${resourceType} resource`);
   }
 

diff --git a/jobs/v4/job_search_create_client_event.js b/jobs/v4/job_search_create_client_event.js
@@ -55,8 +55,7 @@ function sampleCreateClientEvent(projectId, tenantId, requestId, eventId) {
   };
   client
     .createClientEvent(request)
-    .then(responses => {
-      const response = responses[0];
+    .then(() => {
       console.log('Created client event');
     })
     .catch(err => {