chore: delete unused variables (#2052)

GoogleCloudPlatform · Nov 6, 2020 · 764d0fe · 764d0fe
1 parent f5e8de0
commit 764d0fe
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 12 deletions.
diff --git a/functions/billing/index.js b/functions/billing/index.js
@@ -30,7 +30,7 @@ const BOT_ACCESS_TOKEN =
   process.env.BOT_ACCESS_TOKEN || 'xxxx-111111111111-abcdefghidklmnopq';
 const CHANNEL = process.env.SLACK_CHANNEL || 'general';
 
-exports.notifySlack = async (pubsubEvent, context) => {
+exports.notifySlack = async pubsubEvent => {
   const pubsubAttrs = pubsubEvent.attributes;
   const pubsubData = Buffer.from(pubsubEvent.data, 'base64').toString();
   const budgetNotificationText = `${JSON.stringify(
@@ -50,7 +50,7 @@ exports.notifySlack = async (pubsubEvent, context) => {
 // [START functions_billing_stop]
 const billing = google.cloudbilling('v1').projects;
 
-exports.stopBilling = async (pubsubEvent, context) => {
+exports.stopBilling = async pubsubEvent => {
   const pubsubData = JSON.parse(
     Buffer.from(pubsubEvent.data, 'base64').toString()
   );
@@ -122,7 +122,7 @@ const _disableBillingForProject = async projectName => {
 // [END functions_billing_stop]
 
 // Helper function to restart billing (used in tests)
-exports.startBilling = async (pubsubEvent, context) => {
+exports.startBilling = async pubsubEvent => {
   const pubsubData = JSON.parse(
     Buffer.from(pubsubEvent.data, 'base64').toString()
   );
@@ -148,7 +148,7 @@ exports.startBilling = async (pubsubEvent, context) => {
 const compute = google.compute('v1');
 const ZONE = 'us-central1-a';
 
-exports.limitUse = async (pubsubEvent, context) => {
+exports.limitUse = async pubsubEvent => {
   const pubsubData = JSON.parse(
     Buffer.from(pubsubEvent.data, 'base64').toString()
   );
@@ -204,7 +204,7 @@ const _stopInstances = async (projectId, zone, instanceNames) => {
 // [END functions_billing_limit]
 
 // Helper function to restart instances (used in tests)
-exports.startInstances = async (pubsubEvent, context) => {
+exports.startInstances = async () => {
   _setAuthCredential();
   const instanceNames = await _listStoppedInstances(PROJECT_ID, ZONE);
 
@@ -250,7 +250,7 @@ const _startInstances = async (projectId, zone, instanceNames) => {
 };
 
 // Helper function used in tests
-exports.listRunningInstances = async (pubsubEvent, context) => {
+exports.listRunningInstances = async () => {
   _setAuthCredential();
   console.log(PROJECT_ID, ZONE);
   return _listRunningInstances(PROJECT_ID, ZONE);

diff --git a/functions/billing/test/periodic.test.js b/functions/billing/test/periodic.test.js
@@ -22,8 +22,6 @@ const promiseRetry = require('promise-retry');
 const BASE_URL = process.env.BASE_URL || 'http://localhost:8080';
 const cwd = path.join(__dirname, '..');
 
-const {BILLING_ACCOUNT} = process.env;
-
 before(async () => {
   // Re-enable compute instances using the sample file itself
   const {startInstances, listRunningInstances} = require('../');

diff --git a/functions/helloworld/test/index.test.js b/functions/helloworld/test/index.test.js
@@ -15,13 +15,10 @@
 const path = require('path');
 const assert = require('assert');
 const requestRetry = require('requestretry');
-const uuid = require('uuid');
 const sinon = require('sinon');
 const execPromise = require('child-process-promise').exec;
 
 const program = require('..');
-const fileName = `test-${uuid.v4()}.txt`;
-const bucketName = process.env.FUNCTIONS_BUCKET;
 
 const startFF = (target, signature, port) => {
   const cwd = path.join(__dirname, '..');

diff --git a/functions/helloworld/test/sample.integration.pubsub.test.js b/functions/helloworld/test/sample.integration.pubsub.test.js
@@ -82,7 +82,7 @@ describe('functions_helloworld_pubsub integration test', () => {
     assert.strictEqual(response.statusCode, 204);
 
     // Wait for functions-framework process to exit
-    const {stdout, stderr} = await proc;
+    const {stdout} = await proc;
     assert(stdout.includes('Hello, World!'));
   });
   // [START functions_pubsub_integration_test]