* Refactored Pub/Sub samples into nice command-line programs, like th…

…e new Cloud Storage samples

* Brought Pub/Sub samples code coverage up to 98.66%

bigquery/system-test/dataset_size.test.js

@@ -21,7 +21,7 @@ describe('bigquery:dataset_size', function () {
       'bigquery-public-data',
       'hacker_news',
       function (err, size) {
-        assert(!err);
+        assert.ifError(err);
         assert.equal(typeof size, 'string');
         assert(size.indexOf(' GB') === size.length - 3);
         done();

bigquery/system-test/getting_started.test.js

@@ -19,7 +19,7 @@ describe('bigquery:getting_started', function () {
   it('should run a query', function (done) {
     gettingStartedExample.main(
       function (err, rows) {
-        assert(!err);
+        assert.ifError(err);
         assert(Array.isArray(rows));
         assert.equal(rows.length, 10);
         done();

bigquery/system-test/load_data_from_csv.test.js

@@ -39,7 +39,7 @@ describe('bigquery:load_data_from_csv', function () {
           done(err);
         });
       } else {
-        assert(!err);
+        assert.ifError(err);
         // metadata
         assert.equal(results[1].status.state, 'DONE');
         done();

bigquery/system-test/load_data_from_gcs.test.js

@@ -40,7 +40,7 @@ describe('bigquery:load_data_from_gcs', function () {
           done(err);
         });
       } else {
-        assert(!err);
+        assert.ifError(err);
         // metadata
         assert.equal(results[1].status.state, 'DONE');
         done();

computeengine/system-test/vms.test.js

@@ -18,7 +18,7 @@ var vmsExample = require('../vms');
 describe('computeengine:vms', function () {
   it('should retrieve vms', function (done) {
     vmsExample.main(function (err, result) {
-      assert(!err);
+      assert.ifError(err);
       assert(result);
       assert(Array.isArray(result));
       done();

computeengine/system-test/vms_api.test.js

@@ -18,7 +18,7 @@ var vmsExample = require('../vms_api');
 describe('computeengine:vms_api', function () {
   it('should retrieve vms', function (done) {
     vmsExample.main(function (err, result) {
-      assert(!err);
+      assert.ifError(err);
       assert(result);
       done();
     });

datastore/system-test/concepts.test.js

@@ -131,7 +131,7 @@ describe('datastore:concepts', function () {
   it('performs a projection query', function (done) {
     entity.testProperties(function (err, tasks) {
       console.log(err, tasks);
-      assert(!err);
+      assert.ifError(err);
       setTimeout(function () {
         query.testRunQueryProjection(done);
       }, 1000);
@@ -203,7 +203,7 @@ describe('datastore:concepts', function () {
 
   it.skip('allows manual pagination through results', function (done) {
     entity.testBatchUpsert(function (err) {
-      assert(!err);
+      assert.ifError(err);
       setTimeout(function () {
         query.testCursorPaging(done);
       }, 1000);

datastore/system-test/tasks.test.js

@@ -32,7 +32,7 @@ describe('datastore:tasks', function () {
 
   it('should mark a task as done', function (done) {
     getTaskId(function (err, taskId) {
-      assert(!err);
+      assert.ifError(err);
       tasks.updateEntity(taskId, done);
     });
   });
@@ -43,14 +43,14 @@ describe('datastore:tasks', function () {
 
   it('should delete a task', function (done) {
     getTaskId(function (err, taskId) {
-      assert(!err);
+      assert.ifError(err);
       tasks.deleteEntity(taskId, done);
     });
   });
 
   it('should format tasks', function (done) {
     tasks.retrieveEntities(function (err, _tasks) {
-      assert(!err);
+      assert.ifError(err);
       assert.doesNotThrow(function () {
         tasks.formatTasks(_tasks);
       });

language/system-test/analyze.test.js

@@ -21,7 +21,7 @@ describe('language:analyze', function () {
       'sentiment',
       'This gazinga pin is bad and it should feel bad',
       function (err, result) {
-        assert(!err);
+        assert.ifError(err);
         assert(result);
         assert(result.documentSentiment);
         assert(result.documentSentiment.polarity < 0);
@@ -34,7 +34,7 @@ describe('language:analyze', function () {
       'entities',
       'Mark Twain is the author of a book called Tom Sawyer',
       function (err, result) {
-        assert(!err);
+        assert.ifError(err);
         assert(result);
         assert(result.entities && result.entities.length);
         assert(result.entities[0].name === 'Mark Twain');
@@ -51,7 +51,7 @@ describe('language:analyze', function () {
       'buy some better butter - better than this bitter butter - it will ' +
       'make my batter better."',
       function (err, result) {
-        assert(!err);
+        assert.ifError(err);
         assert(result);
         assert(result.sentences && result.sentences.length);
         assert(result.tokens && result.tokens.length > 5);

logging/system-test/export.test.js

@@ -18,7 +18,7 @@ var exportExample = require('../export');
 describe('logging:export', function () {
   it('should list sinks', function (done) {
     exportExample.main(function (err, sinks) {
-      assert(!err);
+      assert.ifError(err);
       assert(sinks, 'should have received sinks');
       assert(Array.isArray(sinks), 'sinks should be an array');
       done();

logging/system-test/list.test.js

@@ -18,7 +18,7 @@ var listExample = require('../list');
 describe('logging:list', function () {
   it('should list entries', function (done) {
     listExample.main(undefined, function (err, entries, nextQuery, apiResponse) {
-      assert(!err);
+      assert.ifError(err);
       assert(entries, 'should have received entries');
       assert(Array.isArray(entries), 'entries should be an array');
       assert(nextQuery, 'should have received nextQuery');

logging/system-test/write.test.js

@@ -21,7 +21,7 @@ describe('logging:write', function () {
       if (err && err.code === 404) {
         return done();
       }
-      assert(!err);
+      assert.ifError(err);
       assert(results.length === 2, 'should have two results');
       done();
     });

monitoring/create_custom_metric.js

@@ -250,12 +250,12 @@ exports.main = function (projectId, name, cb) {
       function (cb) {
         setTimeout(function () {
           customMetrics.writeTimeSeriesForCustomMetric(authClient, cb);
-        }, 5000);
+        }, 10000);
       },
       function (cb) {
         setTimeout(function () {
           customMetrics.listTimeSeries(authClient, cb);
-        }, 5000);
+        }, 10000);
       },
       function (cb) {
         customMetrics.deleteMetric(authClient, cb);

monitoring/system-test/create_custom_metric.test.js

@@ -26,10 +26,7 @@ describe('monitoring:create_custom_metric', function () {
       process.env.GCLOUD_PROJECT,
       Math.random().toString(36).substring(7),
       function (err, results) {
-        assert(!err);
-        // console.log('---------------------------------------------');
-        // console.log(JSON.stringify(results, null, 2));
-        // console.log('---------------------------------------------');
+        assert.ifError(err);
         assert(results.length === 4);
         // Result of creating metric
         assert(typeof results[0].name === 'string');

monitoring/system-test/list_resources.test.js

@@ -20,7 +20,7 @@ describe('monitoring:list_resources', function () {
     listResourcesExample.main(
       process.env.GCLOUD_PROJECT,
       function (err, results) {
-        assert(!err);
+        assert.ifError(err);
         assert(results.length === 3);
         // Monitored resources
         assert(Array.isArray(results[0].resourceDescriptors));

prediction/system-test/hostedmodels.test.js

@@ -18,7 +18,7 @@ var hostedmodels = require('../../prediction/hostedmodels');
 describe('prediction:hostedmodels', function () {
   it('should predict', function (done) {
     hostedmodels.main('good night', function (err, result) {
-      assert(!err);
+      assert.ifError(err);
       assert(result);
       assert(console.log.calledWith('Sentiment for "good night": positive'));
       done();

pubsub/README.md

@@ -11,7 +11,8 @@ allows you to send and receive messages between independent applications.
 
 * [Setup](#setup)
 * [Samples](#samples)
-  * [Subscription](#subscription)
+  * [Topics](#topics)
+  * [Subscriptions](#subscriptions)
   * [IAM](#iam)
 
 ## Setup
@@ -26,24 +27,90 @@ allows you to send and receive messages between independent applications.
 
 ## Samples
 
-### Subscription
+### Topics
 
-View the [documentation][subscription_docs] or the [source code][subscription_code].
+View the [documentation][topics_docs] or the [source code][topics_code].
 
-__Run the sample:__
+__Usage:__ `node topics --help`
 
-    node subscription
+```
+Usage: node topics COMMAND [ARGS...]
 
-[subscription_docs]: https://cloud.google.com/pubsub/subscriber
-[subscription_code]: subscription.js
+Commands:
+
+  create TOPIC_NAME
+  delete TOPIC_NAME
+  publish TOPIC_NAME MESSAGE
+  list
+
+Examples:
+
+  node topics create my-topic
+  node topics list
+  node topics publish my-topic '{"data":"Hello world!"}'
+  node topics delete my-topic
+```
+
+[topics_docs]: https://cloud.google.com/pubsub/publisher
+[topics_code]: topics.js
+
+### Subscriptions
+
+View the [documentation][subscriptions_docs] or the [source code][subscriptions_code].
+
+__Usage:__ `node subscriptions --help`
+
+```
+Usage: node subscriptions COMMAND [ARGS...]
+
+Commands:
+
+  create TOPIC_NAME SUBSCRIPTION_NAME
+  delete SUBSCRIPTION_NAME
+  pull SUBSCRIPTION_NAME
+  list [TOPIC_NAME]
+
+Examples:
+
+  node subscriptions create my-topic my-subscription
+  node subscriptions delete my-subscription
+  node subscriptions pull my-subscription
+  node subscriptions list
+  node subscriptions list my-topic
+```
+
+[subscriptions_docs]: https://cloud.google.com/pubsub/subscriber
+[subscriptions_code]: subscriptions.js
 
 ### IAM
 
 View the [documentation][iam_docs] or the [source code][iam_code].
 
-__Run the sample:__
+__Usage:__ `node iam --help`
+
+```
+Usage: node iam RESOURCE COMMAND [ARGS...]
+
+Resources:
+
+  topics
+  subscriptions
+
+Commands:
+
+  get NAME
+  set NAME
+  test NAME
+
+Examples:
 
-    node iam
+  node iam topics get my-topic
+  node iam topics set my-topic
+  node iam topics test my-topic
+  node iam subscriptions get my-subscription
+  node iam subscriptions set my-subscription
+  node iam subscriptions test my-subscription
+```
 
 [iam_docs]: https://cloud.google.com/pubsub/access_control
-[iam_code]: subscription.js
+[iam_code]: iam.js