Add support for 'Engine' and 'Data Store' resources from the Vertex AI Search and Conversation service

[Pratster95]

This is a PR for Search App TF Provider (DiscoveryEngine)

Closes hashicorp/terraform-provider-google#16787

Adds resource coverage for:

• Data Store resource
• Engine resource

Release Note Template for Downstream PRs (will be copied)

`google_search_and_conversation_data_store`

`google_search_and_conversation_app` - TODO: is it engine?

[modular-magician]

Hello! I am a robot. It looks like you are a: Community Contributor Googler Core Contributor. Tests will run automatically.

@SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 14 files changed, 1585 insertions(+), 2 deletions(-))
Terraform Beta: Diff ( 14 files changed, 1585 insertions(+), 2 deletions(-))
TF Conversion: Diff ( 2 files changed, 257 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_search_and_conversation_app (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_search_and_conversation_app" "primary" {
  collection_id = # value needed
  common_config {
    company_name = # value needed
  }
  data_store_ids    = # value needed
  display_name      = # value needed
  engine_id         = # value needed
  industry_vertical = # value needed
  location          = # value needed
  search_engine_config {
    search_add_ons = # value needed
    search_tier    = # value needed
  }
  solution_type = # value needed
}

Resource: google_search_and_conversation_data_store (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_search_and_conversation_data_store" "primary" {
  collection_id               = # value needed
  create_advanced_site_search = # value needed
  data_store_id               = # value needed
  display_name                = # value needed
  industry_vertical           = # value needed
  location                    = # value needed
  solution_types              = # value needed
}

[modular-magician]

Tests analytics

Total tests: 3333
Passed tests 2996
Skipped tests: 337
Affected tests: 0

Click here to see the affected service packages

all service packages are affected

$\textcolor{green}{\textsf{All tests passed in REPLAYING mode.}}$
View the build log

[SarahFrench]

Hi @Pratster95! Thanks for your PR - could you please follow the guidance in messages like this one about test coverage of the new resources and their fields? This page in our contribution guide should help with first steps: https://googlecloudplatform.github.io/magic-modules/develop/test/ . With tests present in the PR we'll be able to identify any changes needed in the YAML definition of the resources. Thanks!

Edit: also take a look at this check that's linting the YAML files: https://github.com/GoogleCloudPlatform/magic-modules/actions/runs/7454046384/job/20280611905?pr=9774

[SarahFrench]

Should this resource be called 'Engine'? I'm confused at the discrepancy between information in this file and the API's docs

[Pratster95]

@SarahFrench Thanks for this comment. I will update the resource name in my next PR.

[melinath]

Is this the same Data Store resource as was just added in #9682?

[Pratster95]

Is this the same Data Store resource as was just added in #9682?

Yes it is the same. I will pull the latest merged changes for Datastore and create another PR along with the latest changes and acceptance test for Search Engine.