Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Magician check cassettes new #9630

Merged
merged 8 commits into from
Dec 21, 2023
Merged

Magician check cassettes new #9630

merged 8 commits into from
Dec 21, 2023

Conversation

trodge
Copy link
Contributor

@trodge trodge commented Dec 12, 2023 •
edited
Loading

Adds post-merge step to run check-cassettes

Should be merged after #9613

See comparison

Release Note Template for Downstream PRs (will be copied)

@trodge trodge mentioned this pull request Dec 12, 2023
Merged
@trodge trodge requested a review from shuyama1 December 12, 2023 22:37
@trodge trodge marked this pull request as ready for review December 12, 2023 22:37
@trodge trodge mentioned this pull request Dec 12, 2023
Closed
@trodge trodge force-pushed the magician-check-cassettes-new branch from 7530519 to f7191a1 Compare December 13, 2023 21:01
@trodge
Run cassettes on main
7e375ac 
Revert local testing changes

Test: make magician-check-vcr-cassettes the only step

Also collect passing and skipping tests

collectResult no longer returns an error

Remove extra return value

gitignore magician binary

Print logs

Actually set logPaths and cassettePaths

Rework management of environment variables

Remove extra ]

Also print all_tests.log

Echo home

Include HOME in env

Echo path

Use GOCACHE instead of HOME

add -vet=off

Run all tests, skip printing logs

Run 24 tests and upload logs

Add -r and remove logs

Also upload cassettes

Run tests for one resource in recording

Run tests for one resource in replaying

Also capture PATH

Run recording again

Clone hashicorp provider instead of mm

Run all tests

Run replaying

Move check cassettes to push-downstream

Remove echo PATH

change to GA in doc (GoogleCloudPlatform#9491)

Co-authored-by: Edward Sun <[email protected]>

Refactor magician structs (GoogleCloudPlatform#9605)

* Refactored github interfaces

Fixed bug in overriding breaking changes

* gofmt

* Removed GetPullRequestLabelIDs

Use magician for generate comment

Fix formatting of breaking changes

Keep diff string empty

Add missing newline

Add copyright notices

Add missing space

Revert changes from running generate-comment

Run cassettes on main

Print logs

Rework management of environment variables

change to GA in doc (GoogleCloudPlatform#9491)

Co-authored-by: Edward Sun <[email protected]>

git checkout main gcb-generate-diffs-new.yml
@trodge
Move Version into provider package and Repo into source package
ba1c6d8
@trodge
Remove second walk func
af26b8f
@trodge
Add ,
624d6f9
@trodge trodge force-pushed the magician-check-cassettes-new branch from f7191a1 to 624d6f9 Compare December 15, 2023 01:47
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

shuyama1
shuyama1 reviewed Dec 16, 2023
View reviewed changes
Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good! I only have some small questions

.ci/magician/cmd/check_cassettes.go

providerRepo := &source.Repo{
Name: provider.Beta.RepoName(),
Branch: "downstream-pr-" + commit,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we're running against the downstream branch generated in the magician, like https://github.com/modular-magician/terraform-provider-google-beta/tree/downstream-pr-897b7f18d1740bc864111c79fe56bf57c628ecc6 instead of the main of the downstream repos?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, because I expect this branch to be more likely to contain the newest changes at the time we pull.

Copy link
Member

@shuyama1 shuyama1 Dec 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense. One concern that I have is if VCR cassette merger will be finished before it pulls the cassettes? Do we need this step to wait for vcr-cassette-merger?

.ci/magician/cmd/check_cassettes.go Outdated Show resolved Hide resolved
.ci/magician/vcr/tester.go Outdated Show resolved Hide resolved
@trodge trodge requested a review from shuyama1 December 18, 2023 18:33
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

shuyama1
shuyama1 reviewed Dec 20, 2023
View reviewed changes
Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! one small comment

.ci/gcb-push-downstream.yml Outdated Show resolved Hide resolved
@trodge trodge requested a review from shuyama1 December 20, 2023 21:10
@trodge trodge merged commit 4aad699 into GoogleCloudPlatform:main Dec 21, 2023
10 checks passed
@trodge trodge deleted the magician-check-cassettes-new branch December 21, 2023 00:15
kapreus pushed a commit to kapreus/magic-modules that referenced this pull request Jan 2, 2024
@trodge @kapreus
Magician check cassettes new (GoogleCloudPlatform#9630)
b7f2e4c 
* Run cassettes on main

Revert local testing changes

Test: make magician-check-vcr-cassettes the only step

Also collect passing and skipping tests

collectResult no longer returns an error

Remove extra return value

gitignore magician binary

Print logs

Actually set logPaths and cassettePaths

Rework management of environment variables

Remove extra ]

Also print all_tests.log

Echo home

Include HOME in env

Echo path

Use GOCACHE instead of HOME

add -vet=off

Run all tests, skip printing logs

Run 24 tests and upload logs

Add -r and remove logs

Also upload cassettes

Run tests for one resource in recording

Run tests for one resource in replaying

Also capture PATH

Run recording again

Clone hashicorp provider instead of mm

Run all tests

Run replaying

Move check cassettes to push-downstream

Remove echo PATH

change to GA in doc (GoogleCloudPlatform#9491)

Co-authored-by: Edward Sun <[email protected]>

Refactor magician structs (GoogleCloudPlatform#9605)

* Refactored github interfaces

Fixed bug in overriding breaking changes

* gofmt

* Removed GetPullRequestLabelIDs

Use magician for generate comment

Fix formatting of breaking changes

Keep diff string empty

Add missing newline

Add copyright notices

Add missing space

Revert changes from running generate-comment

Run cassettes on main

Print logs

Rework management of environment variables

change to GA in doc (GoogleCloudPlatform#9491)

Co-authored-by: Edward Sun <[email protected]>

git checkout main gcb-generate-diffs-new.yml

* Move Version into provider package and Repo into source package

* Remove second walk func

* Add ,

* Delete unused variable

* Rename bucket

* Include numbers of failed, passed, and skipped tests

* Wait for vcr merge instead of tpgb push
balanaguharsha pushed a commit to balanaguharsha/magic-modules that referenced this pull request May 2, 2024
@trodge @balanaguharsha
Magician check cassettes new (GoogleCloudPlatform#9630)
2ce1a35 
* Run cassettes on main

Revert local testing changes

Test: make magician-check-vcr-cassettes the only step

Also collect passing and skipping tests

collectResult no longer returns an error

Remove extra return value

gitignore magician binary

Print logs

Actually set logPaths and cassettePaths

Rework management of environment variables

Remove extra ]

Also print all_tests.log

Echo home

Include HOME in env

Echo path

Use GOCACHE instead of HOME

add -vet=off

Run all tests, skip printing logs

Run 24 tests and upload logs

Add -r and remove logs

Also upload cassettes

Run tests for one resource in recording

Run tests for one resource in replaying

Also capture PATH

Run recording again

Clone hashicorp provider instead of mm

Run all tests

Run replaying

Move check cassettes to push-downstream

Remove echo PATH

change to GA in doc (GoogleCloudPlatform#9491)

Co-authored-by: Edward Sun <[email protected]>

Refactor magician structs (GoogleCloudPlatform#9605)

* Refactored github interfaces

Fixed bug in overriding breaking changes

* gofmt

* Removed GetPullRequestLabelIDs

Use magician for generate comment

Fix formatting of breaking changes

Keep diff string empty

Add missing newline

Add copyright notices

Add missing space

Revert changes from running generate-comment

Run cassettes on main

Print logs

Rework management of environment variables

change to GA in doc (GoogleCloudPlatform#9491)

Co-authored-by: Edward Sun <[email protected]>

git checkout main gcb-generate-diffs-new.yml

* Move Version into provider package and Repo into source package

* Remove second walk func

* Add ,

* Delete unused variable

* Rename bucket

* Include numbers of failed, passed, and skipped tests

* Wait for vcr merge instead of tpgb push
pengq-google pushed a commit to pengq-google/magic-modules that referenced this pull request May 21, 2024
@trodge @pengq-google
Magician check cassettes new (GoogleCloudPlatform#9630)
1691b00 
* Run cassettes on main

Revert local testing changes

Test: make magician-check-vcr-cassettes the only step

Also collect passing and skipping tests

collectResult no longer returns an error

Remove extra return value

gitignore magician binary

Print logs

Actually set logPaths and cassettePaths

Rework management of environment variables

Remove extra ]

Also print all_tests.log

Echo home

Include HOME in env

Echo path

Use GOCACHE instead of HOME

add -vet=off

Run all tests, skip printing logs

Run 24 tests and upload logs

Add -r and remove logs

Also upload cassettes

Run tests for one resource in recording

Run tests for one resource in replaying

Also capture PATH

Run recording again

Clone hashicorp provider instead of mm

Run all tests

Run replaying

Move check cassettes to push-downstream

Remove echo PATH

change to GA in doc (GoogleCloudPlatform#9491)

Co-authored-by: Edward Sun <[email protected]>

Refactor magician structs (GoogleCloudPlatform#9605)

* Refactored github interfaces

Fixed bug in overriding breaking changes

* gofmt

* Removed GetPullRequestLabelIDs

Use magician for generate comment

Fix formatting of breaking changes

Keep diff string empty

Add missing newline

Add copyright notices

Add missing space

Revert changes from running generate-comment

Run cassettes on main

Print logs

Rework management of environment variables

change to GA in doc (GoogleCloudPlatform#9491)

Co-authored-by: Edward Sun <[email protected]>

git checkout main gcb-generate-diffs-new.yml

* Move Version into provider package and Repo into source package

* Remove second walk func

* Add ,

* Delete unused variable

* Rename bucket

* Include numbers of failed, passed, and skipped tests

* Wait for vcr merge instead of tpgb push
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuyama1 shuyama1 shuyama1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trodge @modular-magician @shuyama1