Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guest_os_features and licenses to disk and regional disk #7970

Merged
merged 1 commit into from
May 19, 2023

Conversation

rosmo
Copy link
Contributor

@rosmo rosmo commented May 17, 2023

To support replicating boot disk with asynchronous replication, adding guest_os_features and licenses support to google_compute_disk and google_compute_region_disk.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Generated Terraform providers, and ran make test and make lint in the generated providers to ensure it passes unit and linter tests.
  • Ran relevant acceptance tests using my own Google Cloud project and credentials (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

compute: added `guest_os_features` and `licenses` fields to `google_compute_disk` and `google_compute_region_disk`

@modular-magician modular-magician requested a review from c2thorn May 17, 2023 20:37
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @c2thorn, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.


@rosmo rosmo changed the title Added guest_os_features and licenses to disk and regional disk Add guest_os_features and licenses to disk and regional disk May 17, 2023
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 462 insertions(+))
Terraform Beta: Diff ( 6 files changed, 462 insertions(+))
TF Conversion: Diff ( 4 files changed, 115 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 250 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2744
Passed tests 2449
Skipped tests: 283
Affected tests: 12

Action taken

Found 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeRegionDisk_regionDiskFeaturesExample|TestAccComputeDisk_diskFeaturesExample|TestAccComputeFirewallPolicyRule_multipleRules|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccAlloydbBackup_missingLocation|TestAccAlloydbCluster_missingLocation|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccSqlUser_postgresAbandon|TestAccSqlUser_postgresIAM|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccSqlUser_postgres|TestAccDataSourceAlloydbLocations_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccComputeDisk_diskFeaturesExample[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccSqlUser_postgresAbandon[Debug log]
TestAccSqlUser_postgresIAM[Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]
TestAccSqlUser_postgres[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]

Tests failed during RECORDING mode:
TestAccComputeRegionDisk_regionDiskFeaturesExample[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@rosmo rosmo force-pushed the compute-disk-features branch from 8f3c3f6 to 6542199 Compare May 18, 2023 03:53
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 6 files changed, 458 insertions(+))
Terraform Beta: Diff ( 6 files changed, 458 insertions(+))
TF Conversion: Diff ( 4 files changed, 115 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 248 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2744
Passed tests 2453
Skipped tests: 283
Affected tests: 8

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeRegionDisk_regionDiskFeaturesExample|TestAccAlloydbBackup_missingLocation|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample|TestAccAlloydbCluster_missingLocation|TestAccComputeFirewallPolicyRule_multipleRules|TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccDataSourceAlloydbLocations_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccComputeRegionDisk_regionDiskFeaturesExample[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]

Tests failed during RECORDING mode:
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@rosmo rosmo force-pushed the compute-disk-features branch from 6542199 to 26c6179 Compare May 18, 2023 08:02
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 8 files changed, 601 insertions(+))
Terraform Beta: Diff ( 8 files changed, 601 insertions(+))
TF Conversion: Diff ( 4 files changed, 115 insertions(+), 3 deletions(-))
TF OiCS: Diff ( 8 files changed, 248 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2746
Passed tests 2451
Skipped tests: 283
Affected tests: 12

Action taken

Found 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccDataSourceGoogleFirebaseAndroidAppConfig|TestAccDataSourceAlloydbLocations_basic|TestAccComputeRegionDisk_featuresUpdated|TestAccComputeDisk_featuresUpdated|TestAccBigqueryConnectionConnection_bigqueryConnectionCloudResourceExample|TestAccBigqueryReservationCapacityCommitment_bigqueryReservationCapacityCommitmentBasicExample|TestAccComputeFirewallPolicyRule_multipleRules|TestAccAlloydbCluster_missingLocation|TestAccIapWebIamBindingGenerated_withCondition|TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example|TestAccAlloydbBackup_missingLocation|TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccDataSourceGoogleFirebaseAndroidAppConfig[Debug log]
TestAccDataSourceAlloydbLocations_basic[Debug log]
TestAccComputeRegionDisk_featuresUpdated[Debug log]
TestAccComputeDisk_featuresUpdated[Debug log]
TestAccBigqueryConnectionConnection_bigqueryConnectionCloudResourceExample[Debug log]
TestAccAlloydbCluster_missingLocation[Debug log]
TestAccIapWebIamBindingGenerated_withCondition[Debug log]
TestAccApigeeKeystoresAliasesPkcs12_ApigeeKeystoresAliasesPkcs12Example[Debug log]
TestAccAlloydbBackup_missingLocation[Debug log]
TestAccApigeeKeystoresAliasesKeyCertFile_apigeeKeystoresAliasesKeyCertFileTestExample[Debug log]

Tests failed during RECORDING mode:
TestAccBigqueryReservationCapacityCommitment_bigqueryReservationCapacityCommitmentBasicExample[Error message] [Debug log]
TestAccComputeFirewallPolicyRule_multipleRules[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

@rosmo
Copy link
Contributor Author

rosmo commented May 18, 2023

@c2thorn looks like unrelated test failures, this should be good to go.

Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants