Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(redis): auth_string optional parameter does not exist #7194

Merged
merged 2 commits into from
Feb 3, 2023
Merged

doc(redis): auth_string optional parameter does not exist #7194

merged 2 commits into from
Feb 3, 2023

Conversation

Pinimo
Copy link
Contributor

@Pinimo Pinimo commented Feb 1, 2023

Part of hashicorp/terraform-provider-google#9958
Fixes hashicorp/terraform-provider-google#12563

redis: Remove `auth_string` parameter from doc as it is only an output

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

@google-cla
Copy link

google-cla bot commented Feb 1, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Pinimo Pinimo changed the title doc(redis): remove optional_properties with deprecated auth_string doc(redis): auth_string optional parameter does not exist Feb 1, 2023
@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I've detected that you're a community contributor. @zli82016, a repository maintainer, has been assigned to assist you and help review your changes.

❓ First time contributing? Click here for more details

Your assigned reviewer will help review your code by:

  • Ensuring it's backwards compatible, covers common error cases, etc.
  • Summarizing the change into a user-facing changelog note.
  • Passes tests, either our "VCR" suite, a set of presubmit tests, or with manual test runs.

You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails.

If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox.


@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 1 deletion(-))
Terraform Beta: Diff ( 1 file changed, 1 deletion(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@Pinimo Pinimo marked this pull request as ready for review February 3, 2023 14:07
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 1 deletion(-))
Terraform Beta: Diff ( 1 file changed, 1 deletion(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@Pinimo
Copy link
Contributor Author

Pinimo commented Feb 3, 2023

Although I was able to build the providers, I would prefer not to run tests, because I don't want to run them on any corporate GCP project, and my edit is only about documentation. I hope this makes sense 🙂

@zli82016
Copy link
Member

zli82016 commented Feb 3, 2023

Although I was able to build the providers, I would prefer not to run tests, because I don't want to run them on any corporate GCP project, and my edit is only about documentation. I hope this makes sense 🙂

It makes sense, as it is only documentation change.

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zli82016 zli82016 merged commit df2f16c into GoogleCloudPlatform:main Feb 3, 2023
@Pinimo Pinimo deleted the doc/redis-instance-auth-string branch February 6, 2023 09:03
kubalaguna pushed a commit to kubalaguna/magic-modules that referenced this pull request Feb 27, 2023
…dPlatform#7194)

* doc(redis): remove optional_properties with deprecated auth_string

Fixes hashicorp/terraform-provider-google#9958

* doc(redis): also remove containing document
ericayyliu pushed a commit to ericayyliu/magic-modules that referenced this pull request Jul 26, 2023
…dPlatform#7194)

* doc(redis): remove optional_properties with deprecated auth_string

Fixes hashicorp/terraform-provider-google#9958

* doc(redis): also remove containing document
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

google_redis_instance - auth_string
3 participants