potential fix for a crash in google_storage_bucket when providers upgrade to 4.42.0

[shuyama1]

Fixes hashicorp/terraform-provider-google#12917

If this PR is for Terraform, I acknowledge that I have:

• Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
• Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
• Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
• Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
• Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

storage: fixed a crash in `google_storage_bucket` when upgrading provider to version `4.42.0` with `lifecycle_rule.condition.age` unset

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 1 file changed, 3 insertions(+), 1 deletion(-))
Terraform Beta: Diff ( 1 file changed, 3 insertions(+), 1 deletion(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2210
Passed tests 1970
Skipped tests: 239
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccBigQueryDataTable_bigtable

[modular-magician]

Tests passed during RECORDING mode:
TestAccBigQueryDataTable_bigtable[Debug log]

All tests passed
View the build log or the debug log for each test

[rileykarson]

Do we have a good idea why different provider versions act differently here?

My hypothesis was that the library upgrade + expander changes in https://github.com/GoogleCloudPlatform/magic-modules/pull/6635/files result in a different message to the API, but that would explain 4.41.0 -> 4.42.0 causing problems, not 4.37.0 like seems to be discussed as the first failing version on the issue.

[shuyama1]

My hypothesis was that the library upgrade + expander changes in https://github.com/GoogleCloudPlatform/magic-modules/pull/6635/files result in a different message to the API

Yeah, I think that's the root cause. The reason only 4.37.0 or earlier would cause the problem but 4.38.0+ would not is that we introduced the change #6573 in version 4.38.0 where we started to force sending the age field.

[rileykarson]

Ah, force sending from 4.38.0 onwards explains what I was missing. Thanks!