switch deletion_policy to virtual field for google_firebase_web_app

[ScottSuarez]

Fix for issues caused by #6652

This new field was forcing recreation due to not being set on READ.

abandon default forcing recreation.

  # google_firebase_web_app.skip_delete must be replaced
-/+ resource "google_firebase_web_app" "skip_delete" {
      ~ app_id          = "1:82023037933:web:5ec7d3d6a16d2b322945e4" -> (known after apply)
      + deletion_policy = "ABANDON" # forces replacement
      ~ id              = "projects/scottsuarez-graphite/webApps/1:82023037933:web:5ec7d3d6a16d2b322945e4" -> (known after apply)
      ~ name            = "projects/scottsuarez-graphite/webApps/1:82023037933:web:5ec7d3d6a16d2b322945e4" -> (known after apply)
        # (2 unchanged attributes hidden)
    }

Plan: 1 to add, 0 to change, 1 to destroy.

Although, even adding a value with a default will break configurations since we don't read this value anywhere. This leads me to believe adding any value that has a default will encounter this unless it's set on read if the api doesn't return it. It looks like the normal generator save url-param-only already accounts for this.

Terraform will perform the following actions:

  # google_firebase_web_app.skip_delete will be updated in-place
  ~ resource "google_firebase_web_app" "skip_delete" {
      + deletion_policy = "ABANDON"
        id              = "projects/scottsuarez-graphite/webApps/1:82023037933:web:5ec7d3d6a16d2b322945e4"
        name            = "projects/scottsuarez-graphite/webApps/1:82023037933:web:5ec7d3d6a16d2b322945e4"
        # (4 unchanged attributes hidden)
    }

Plan: 0 to add, 1 to change, 0 to destroy.

Switching to a virtual field resolved this.

No changes. Your infrastructure matches the configuration.

Release Note Template for Downstream PRs (will be copied)

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 65 files changed, 82 insertions(+), 81 deletions(-))
Terraform Beta: Diff ( 74 files changed, 97 insertions(+), 99 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 65 files changed, 82 insertions(+), 81 deletions(-))
Terraform Beta: Diff ( 74 files changed, 97 insertions(+), 99 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[rileykarson]

I just wanted to call to attention that this change makes the field updatable. I think that's a positive thing- there's no reason it had to recreate the resource in the first place, and recreation would have actually been undesirable imo. That meant there was no way to change the deletion policy without doing a deletion!

It looks like the normal generator save url-param-only already accounts for this.

Fields present in the API aren't a problem because their values get read during the refresh prior to plan. They do actually cause issues if you do a provider upgrade and then a refreshless plan, but that's an uncommon move and the fix is expensive (doing a lot of state upgrades).

url_param_only is really meant to serve a specific purpose, fields in the URL that will never change, but the functionality is useful so it got used for other purposes. That was part of the motivation for introducing the virtual field override in the first place!

[modular-magician]

Tests analytics

Total tests: 2207
Passed tests 1966
Skipped tests: 239
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccFirebaseWebApp_firebaseWebAppBasicExample

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccFirebaseWebApp_firebaseWebAppBasicExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 14 files changed, 82 insertions(+), 26 deletions(-))
Terraform Beta: Diff ( 16 files changed, 97 insertions(+), 36 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[modular-magician]

Tests analytics

Total tests: 2207
Passed tests 1966
Skipped tests: 239
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease|TestAccFirebaseWebApp_firebaseWebAppBasicExample

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccFirebaseWebApp_firebaseWebAppBasicExample[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

Terraform GA: Diff ( 14 files changed, 82 insertions(+), 26 deletions(-))
Terraform Beta: Diff ( 16 files changed, 97 insertions(+), 36 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

[rileykarson]

Suggested change

	serving traffic. Set to `DELETE` to delete the WebApp. Default to `ABANDON`
	serving traffic. Set to `DELETE` to delete the WebApp. Defaults to `ABANDON`.

[rileykarson]

We may want to call out something about importing the field in the docs, i.e.

Upon import, this field will always take on the default value of "ABANDON", regardless of what's specified in configuration. If you have another value set, a diff will appear in terraform plan. Run terraform apply to apply that value.

[melinath]

this seems like not a great experience - would this be possible for us to fix / do we already have a ticket open to fix it?

[rileykarson]

hashicorp/terraform-plugin-framework#62

[modular-magician]

Tests analytics

Total tests: 2207
Passed tests 1967
Skipped tests: 239
Failed tests: 1

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccFirebaserulesRelease_BasicRelease

[modular-magician]

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

All tests passed
View the build log or the debug log for each test

[rileykarson]

fyi @melinath: We'll want to hold/cherry-pick for this fix, or revert the original change