-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Config entity to Identitytoolkit #6587
Conversation
Hello! I am a robot who works on Magic Modules PRs. I've detected that you're a community contributor. @ScottSuarez, a repository maintainer, has been assigned to assist you and help review your changes. ❓ First time contributing? Click here for more detailsYour assigned reviewer will help review your code by:
You can help make sure that review is quick by running local tests and ensuring they're passing in between each push you make to your PR's branch. Also, try to leave a comment with each push you make, as pushes generally don't generate emails. If your reviewer doesn't get back to you within a week after your most recent change, please feel free to leave a comment on the issue asking them to take a look! In the absence of a dedicated review dashboard most maintainers manage their pending reviews through email, and those will sometimes get lost in their inbox. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 4 files changed, 422 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccFirebaserulesRelease_BasicRelease|TestAccComputeInstance_soleTenantNodeAffinities|TestAccIdentityPlatformConfig_identityPlatformConfigBasicExample |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
The test failure appears to be with how the test is being run by the Cloud Build:
This test is patterned after the pre-existing Firebase Project Basic test, as it needs a new Cloud Project for each run. Can you advise what you'd like me to do here? |
Here is an example of a project being provisioned. I would look at this example and compare it to your own. |
I've updated the CL with the minor deltas from the example you gave, but not clear they are really going to address the Service account's missing permission to create projects. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 4 files changed, 436 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccComputeInstance_soleTenantNodeAffinities |
Tests failed during RECORDING mode: Please fix these to complete your PR |
The remaining test failure doesn't appear to be from my changes, but instead a different entity that is running out of resources:
Since I've made not changes to compute instances or their tenant nodes, it seems unlikely the failure originates from this request? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While everything functionally looks good here. Whats the deletion result? ie, what happens when you delete this resource?
Don't worry about the test. Its unrelated.
This resource is unfortunately a Latch / Project-singleton resource, it cannot be deleted one added to a project (though the Identity Providers which are tied to this resource can be zeroed out & disabled ex: Default Identity Provider. The underlying API resource only has GET and Update (plus the :initializeIdentityPlatform custom verb that must be called before other operations will work) |
I see so this a one-off initialize resource. Could we quantify that information in the description of the resource so consumers are aware? Perhaps with links to further documentation. |
…ablement (and later will hold project wide configuration settings
The resource is also a project-singleton configuration (there are many more field that can be added but we are trying to decouple allowing initialization from the work needed to enable the rest of the custom project-level configuration management since not all customers need the latter). Additional documentation is already linked in the Guides & API fields. I've adjusted the docs some, though the old documentation (such as it was) was directly from the underlying API. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform GA: Diff ( 4 files changed, 442 insertions(+), 2 deletions(-)) |
Tests analyticsTotal tests: Action takenTriggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed testsTestAccComputeInstance_soleTenantNodeAffinities|TestAccPrivatecaCaPoolIamPolicyGenerated_withCondition|TestAccStorageTransferJob_transferOptions|TestAccComputeInstanceIamPolicyGenerated_withCondition|TestAccComputeBackendServiceIamPolicyGenerated_withCondition|TestAccComputeRegionBackendServiceIamPolicyGenerated_withCondition|TestAccComputeMachineImageIamPolicyGenerated_withCondition |
Tests passed during RECORDING mode: Tests failed during RECORDING mode: Please fix these to complete your PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Tyler !
Introduce a minimal Config entity to indentitytoolkit that will allow it to be problematically enabled for Billed projects. Addition of the various other Project Configuration fields will be left to a future PR.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)