Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated some tests from debian-9 to debian-11 (14/?) #6367

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Conversation

melinath
Copy link
Member

@melinath melinath commented Aug 2, 2022

this is the last one from splitting apart the first PR.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)


@melinath melinath requested a review from megan07 August 2, 2022 20:35
@melinath
Copy link
Member Author

melinath commented Aug 2, 2022

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 1 file changed, 68 insertions(+), 68 deletions(-))
Terraform Beta: Diff ( 1 file changed, 69 insertions(+), 69 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2126
Passed tests 1825
Skipped tests: 226
Failed tests: 75

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccComputeInstance_networkTier|TestAccComputeInstance_desiredStatusTerminatedUpdateFields|TestAccComputeInstance_desiredStatusUpdateBasic|TestAccComputeInstance_spotVM_update|TestAccComputeInstance_networkIPAuto|TestAccComputeInstance_desiredStatusOnCreation|TestAccComputeInstance_subnet_custom|TestAccComputeInstance_queueCount|TestAccComputeInstance_subnet_auto|TestAccComputeInstance_subnetworkUpdate|TestAccComputeInstance_attachedDisk_modeRo|TestAccComputeInstance_hostname|TestAccComputeInstance_attachedDisk_sourceUrl|TestAccComputeInstance_secondaryAliasIpRange|TestAccComputeInstance_resourcePolicyCollocate|TestAccComputeInstance_reservationAffinities|TestAccComputeInstance_primaryAliasIpRange|TestAccComputeInstance_attachedDisk|TestAccComputeInstance_deletionProtectionExplicitTrueAndUpdateFalse|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeInstance_deletionProtectionExplicitFalse|TestAccComputeInstance_updateTerminated_desiredStatusRunning_notAllowStoppingForUpdate|TestAccComputeInstance_updateTerminated_desiredStatusTerminated_notAllowStoppingForUpdate|TestAccComputeInstance_minCpuPlatform|TestAccComputeInstance_kmsDiskEncryption|TestAccComputeInstance_scheduling|TestAccComputeInstance_updateTerminated_desiredStatusTerminated_allowStoppingForUpdate|TestAccComputeInstance_serviceAccount_updated0to1to0scopes|TestAccComputeInstance_updateTerminated_desiredStatusNotSet_allowStoppingForUpdate|TestAccComputeInstance_serviceAccount_updated|TestAccComputeInstance_guestAcceleratorSkip|TestAccComputeInstance_updateRunning_desiredStatusTerminated_notAllowStoppingForUpdate|TestAccComputeInstance_updateRunning_desiredStatusTerminated_allowStoppingForUpdate|TestAccComputeInstance_guestAccelerator|TestAccComputeInstance_updateTerminated_desiredStatusNotSet_notAllowStoppingForUpdate|TestAccComputeInstance_updateRunning_desiredStatusRunning_notAllowStoppingForUpdate|TestAccComputeInstance_updateTerminated_desiredStatusRunning_allowStoppingForUpdate|TestAccComputeInstance_diskEncryptionRestart|TestAccComputeInstance_diskEncryption|TestAccComputeInstance_serviceAccount|TestAccComputeInstance_updateRunning_desiredStatusNotSet_notAllowStoppingForUpdate|TestAccComputeInstance_PTRRecord|TestAccComputeInstance_resourcePolicyUpdate|TestAccComputeInstance_updateRunning_desiredStatusRunning_allowStoppingForUpdate|TestAccComputeInstance_multiNic|TestAccComputeInstance_IPv6|TestAccComputeInstance_forceChangeMachineTypeManually|TestAccComputeInstance_stopInstanceToUpdate|TestAccComputeInstance_IP|TestAccComputeInstance_update|TestAccComputeInstance_basic5|TestAccComputeInstance_networkPerformanceConfig|TestAccComputeInstance_basic4|TestAccComputeInstance_forceNewAndChangeMetadata|TestAccComputeInstance_private_image_family|TestAccComputeInstance_network_ip_custom|TestAccComputeInstance_basic3|TestAccComputeInstance_basic2|TestAccComputeInstance_bootDisk_mode|TestAccComputeInstance_bootDisk_type|TestAccComputeInstance_basic1|TestAccComputeInstance_bootDisk_source|TestAccComputeInstance_scratchDisk|TestAccComputeInstance_attachedDiskUpdate|TestAccComputeInstance_bootDisk_sourceUrl|TestAccCloudFunctions2Function_fullUpdate|TestAccCloudRunService_cloudRunServiceStaticOutboundExample|TestAccCloudfunctions2function_cloudfunctions2BasicAuditlogsExample|TestAccCloudfunctions2function_cloudfunctions2BasicGcsExample|TestAccActiveDirectoryPeering_activeDirectoryPeeringBasicExample|TestAccActiveDirectoryDomain_update|TestAccActiveDirectoryDomain_activeDirectoryDomainBasicExample|TestAccCGCSnippet_eventarcWorkflowsExample|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccSqlUser_mysqlDisabled

@melinath
Copy link
Member Author

melinath commented Aug 3, 2022

Merging even though the tests are still running since this compiles and is test-only (and the test will fail without this change)

@melinath melinath merged commit cbeb4db into main Aug 3, 2022
@modular-magician
Copy link
Collaborator

The provider crashed while running the VCR tests in RECORDING mode
Please fix it to complete your PR
View the build log

@ScottSuarez
Copy link
Contributor

ScottSuarez commented Aug 24, 2022

Ah looks like this caused vcr failures since the cassettes were invalidated and underlying tests were sad.

Merging even though the tests are still running since this compiles and is test-only (and the test will fail without this change)

context

@melinath melinath deleted the debian-11-14 branch August 24, 2022 20:41
hao-nan-li pushed a commit to hao-nan-li/magic-modules that referenced this pull request Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants