fix import for bigquery-data-transfer resource #6227

ScottSuarez · 2022-07-06T19:15:20Z

closes hashicorp/terraform-provider-google#12011

Release Note Template for Downstream PRs (will be copied)

bigquery: fixed import for `google_bigquery_data_transfer_config`

modular-magician · 2022-07-06T19:28:30Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 22 insertions(+), 12 deletions(-))
Terraform Beta: Diff ( 3 files changed, 22 insertions(+), 12 deletions(-))
TF Validator: Diff ( 3 files changed, 4 insertions(+), 4 deletions(-))

modular-magician · 2022-07-06T20:07:13Z

Tests analytics

Total tests: 2088
Passed tests 1858
Skipped tests: 226
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccBigqueryDataTransferConfig|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccFirebaserulesRelease_BasicRelease|TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation

modular-magician · 2022-07-06T20:08:41Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[view]

Tests failed during RECORDING mode:
TestAccBigqueryDataTransferConfig[view]
TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation[view]
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]

Please fix these to complete your PR
View the build log or the debug log for each test

ScottSuarez · 2022-07-08T18:24:51Z

@shuyama1 , any idea why the logs for TestAccBigqueryDataTransferConfig failed to upload?

shuyama1 · 2022-07-08T18:34:21Z

I think it's the test set that contains tests running serially. Click the debug log, you should be able to see the test logs I think.

…odules into bqdt-fix-import

modular-magician · 2022-07-08T20:05:55Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 26 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 3 files changed, 26 insertions(+), 13 deletions(-))
TF Validator: Diff ( 3 files changed, 4 insertions(+), 4 deletions(-))

modular-magician · 2022-07-08T20:44:01Z

Tests analytics

Total tests: 2091
Passed tests 1861
Skipped tests: 226
Failed tests: 4

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccBigqueryDataTransferConfig|TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccFirebaserulesRelease_BasicRelease

modular-magician · 2022-07-08T20:45:47Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[view]

Tests failed during RECORDING mode:
TestAccBigqueryDataTransferConfig[view]
TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation[view]
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2022-07-08T21:21:14Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 26 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 3 files changed, 26 insertions(+), 13 deletions(-))
TF Validator: Diff ( 3 files changed, 4 insertions(+), 4 deletions(-))

modular-magician · 2022-07-08T22:06:10Z

Tests analytics

Total tests: 2091
Passed tests 1862
Skipped tests: 226
Failed tests: 3

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccBigqueryDataTransferConfig|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation

modular-magician · 2022-07-08T22:07:22Z

Tests failed during RECORDING mode:
TestAccBigqueryDataTransferConfig[view]
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]
TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation[view]

Please fix these to complete your PR
View the build log or the debug log for each test

ScottSuarez · 2022-07-11T20:55:02Z

/gcbrun

modular-magician · 2022-07-11T21:08:06Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 26 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 3 files changed, 26 insertions(+), 13 deletions(-))
TF Validator: Diff ( 3 files changed, 4 insertions(+), 4 deletions(-))

modular-magician · 2022-07-11T21:53:59Z

Tests analytics

Total tests: 2093
Passed tests 1862
Skipped tests: 226
Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccBigqueryDataTransferConfig|TestAccFirebaserulesRelease_BasicRelease|TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample|TestAccSqlUser_mysqlDisabled

modular-magician · 2022-07-11T22:08:47Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[view]
TestAccSqlUser_mysqlDisabled[view]

Tests failed during RECORDING mode:
TestAccBigqueryDataTransferConfig[view]
TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation[view]
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]

Please fix these to complete your PR
View the build log or the debug log for each test

kanata2 · 2022-09-06T11:03:18Z

@ScottSuarez
Hi, thanks for your great work. What is the current status of this PR?

lodotek · 2022-09-23T18:55:07Z

Bump. Can we please get this merged in?

Thank you...

ScottSuarez · 2022-09-23T21:24:11Z

There are outstanding issues with this change that need to be looked at. WIth my queue of work and priorities I haven't had time to investigate this further.

…odules into bqdt-fix-import

modular-magician · 2022-10-14T18:39:14Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 26 insertions(+), 13 deletions(-))
Terraform Beta: Diff ( 3 files changed, 26 insertions(+), 13 deletions(-))
TF Validator: Diff ( 3 files changed, 4 insertions(+), 4 deletions(-))

modular-magician · 2022-10-17T20:41:26Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 27 insertions(+), 14 deletions(-))
Terraform Beta: Diff ( 3 files changed, 27 insertions(+), 14 deletions(-))
TF Validator: Diff ( 3 files changed, 4 insertions(+), 4 deletions(-))

modular-magician · 2022-10-17T21:26:26Z

Tests analytics

Total tests: 2191
Passed tests 1950
Skipped tests: 239
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccBigqueryDataTransferConfig|TestAccBillingSubaccount_renameOnDestroy

modular-magician · 2022-10-17T21:27:46Z

Tests passed during RECORDING mode:
TestAccBillingSubaccount_renameOnDestroy[Debug log]

Tests failed during RECORDING mode:
TestAccBigqueryDataTransferConfig[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

…c-modules into bqdt-fix-import

modular-magician · 2022-10-17T21:56:52Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 33 insertions(+), 20 deletions(-))
Terraform Beta: Diff ( 4 files changed, 33 insertions(+), 20 deletions(-))
TF Validator: Diff ( 3 files changed, 4 insertions(+), 4 deletions(-))

modular-magician · 2022-10-17T22:41:10Z

Tests analytics

Total tests: 2192
Passed tests 1945
Skipped tests: 239
Failed tests: 8

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccBigqueryDataTransferConfig|TestAccComputeRouterNat_update|TestAccComputeRouterNat_basic|TestAccComputeRouterNat_withPortAllocationMethods|TestAccComputeRouterNat_withManualIpAndSubnetConfiguration|TestAccComputeRouterNat_removeLogConfig|TestAccComputeRouterNat_withNatIpsAndDrainNatIps|TestAccComputeForwardingRule_update

modular-magician · 2022-10-17T22:46:13Z

Tests passed during RECORDING mode:
TestAccComputeRouterNat_update[Debug log]
TestAccComputeRouterNat_basic[Debug log]
TestAccComputeRouterNat_withPortAllocationMethods[Debug log]
TestAccComputeRouterNat_withManualIpAndSubnetConfiguration[Debug log]
TestAccComputeRouterNat_removeLogConfig[Debug log]
TestAccComputeRouterNat_withNatIpsAndDrainNatIps[Debug log]
TestAccComputeForwardingRule_update[Debug log]

Tests failed during RECORDING mode:
TestAccBigqueryDataTransferConfig[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

…odules into bqdt-fix-import

modular-magician · 2022-10-18T17:56:01Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 36 insertions(+), 23 deletions(-))
Terraform Beta: Diff ( 4 files changed, 36 insertions(+), 23 deletions(-))
TF Validator: Diff ( 3 files changed, 4 insertions(+), 4 deletions(-))

modular-magician · 2022-10-18T18:44:39Z

Tests analytics

Total tests: 2193
Passed tests 1946
Skipped tests: 239
Failed tests: 8

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccBigqueryDataTransferConfig|TestAccFirebaserulesRelease_BasicRelease|TestAccComputeRouterNat_withNatIpsAndDrainNatIps|TestAccComputeRouterNat_withPortAllocationMethods|TestAccComputeRouterNat_withManualIpAndSubnetConfiguration|TestAccComputeRouterNat_removeLogConfig|TestAccComputeRouterNat_update|TestAccComputeRouterNat_basic

modular-magician · 2022-10-18T18:49:32Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]
TestAccComputeRouterNat_withNatIpsAndDrainNatIps[Debug log]
TestAccComputeRouterNat_withPortAllocationMethods[Debug log]
TestAccComputeRouterNat_withManualIpAndSubnetConfiguration[Debug log]
TestAccComputeRouterNat_removeLogConfig[Debug log]
TestAccComputeRouterNat_update[Debug log]
TestAccComputeRouterNat_basic[Debug log]

Tests failed during RECORDING mode:
TestAccBigqueryDataTransferConfig[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

modular-magician · 2022-10-18T19:32:04Z

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 37 insertions(+), 24 deletions(-))
Terraform Beta: Diff ( 4 files changed, 37 insertions(+), 24 deletions(-))
TF Validator: Diff ( 3 files changed, 4 insertions(+), 4 deletions(-))

modular-magician · 2022-10-18T20:20:50Z

Tests analytics

Total tests: 2193
Passed tests 1952
Skipped tests: 239
Failed tests: 2

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests

TestAccBigqueryDataTransferConfig|TestAccFirebaserulesRelease_BasicRelease

modular-magician · 2022-10-18T20:22:04Z

Tests passed during RECORDING mode:
TestAccFirebaserulesRelease_BasicRelease[Debug log]

Tests failed during RECORDING mode:
TestAccBigqueryDataTransferConfig[Error message] [Debug log]

Please fix these to complete your PR
View the build log or the debug log for each test

fix import for bigquery-data-transfer resource

ebae2a9

ScottSuarez added 2 commits July 8, 2022 12:49

Merge branch 'main' of https://github.com/GoogleCloudPlatform/magic-m…

185f327

…odules into bqdt-fix-import

name from self_link

8c0b555

meep

9e17d5d

Merge branch 'main' of https://github.com/GoogleCloudPlatform/magic-m…

8d6ad6c

…odules into bqdt-fix-import

ScottSuarez and others added 3 commits October 14, 2022 15:14

set computed name to the resource name

8b5cd9d

update file name

c725b86

Update set_computed_name_to_resource_name.erb

cc1b210

ScottSuarez requested review from a team and removed request for a team October 17, 2022 20:47

ScottSuarez requested review from roaks3 and shuyama1 and removed request for roaks3 October 17, 2022 20:47

ScottSuarez added 2 commits October 17, 2022 14:40

update import

e4ea164

Merge branch 'bqdt-fix-import' of https://github.com/ScottSuarez/magi…

3efbbb9

…c-modules into bqdt-fix-import

ScottSuarez added 2 commits October 18, 2022 10:40

Merge branch 'main' of https://github.com/GoogleCloudPlatform/magic-m…

6fbde3c

…odules into bqdt-fix-import

add ignore on new test

19e2367

US -> us to match import state verify

07ee593

rileykarson added the stale-pr-closed label Feb 8, 2023

rileykarson closed this Feb 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix import for bigquery-data-transfer resource #6227

fix import for bigquery-data-transfer resource #6227

ScottSuarez commented Jul 6, 2022 •

edited

Loading

modular-magician commented Jul 6, 2022

modular-magician commented Jul 6, 2022

modular-magician commented Jul 6, 2022

ScottSuarez commented Jul 8, 2022

shuyama1 commented Jul 8, 2022

modular-magician commented Jul 8, 2022

modular-magician commented Jul 8, 2022

modular-magician commented Jul 8, 2022

modular-magician commented Jul 8, 2022

modular-magician commented Jul 8, 2022

modular-magician commented Jul 8, 2022

ScottSuarez commented Jul 11, 2022

modular-magician commented Jul 11, 2022

modular-magician commented Jul 11, 2022

modular-magician commented Jul 11, 2022

kanata2 commented Sep 6, 2022

lodotek commented Sep 23, 2022

ScottSuarez commented Sep 23, 2022 •

edited

Loading

modular-magician commented Oct 14, 2022

modular-magician commented Oct 17, 2022

modular-magician commented Oct 17, 2022

modular-magician commented Oct 17, 2022

modular-magician commented Oct 17, 2022

modular-magician commented Oct 17, 2022

modular-magician commented Oct 17, 2022

modular-magician commented Oct 18, 2022

modular-magician commented Oct 18, 2022

modular-magician commented Oct 18, 2022

modular-magician commented Oct 18, 2022

modular-magician commented Oct 18, 2022

modular-magician commented Oct 18, 2022

fix import for bigquery-data-transfer resource #6227

fix import for bigquery-data-transfer resource #6227

Conversation

ScottSuarez commented Jul 6, 2022 • edited Loading

modular-magician commented Jul 6, 2022

Diff report:

modular-magician commented Jul 6, 2022

Tests analytics

Action taken

modular-magician commented Jul 6, 2022

ScottSuarez commented Jul 8, 2022

shuyama1 commented Jul 8, 2022

modular-magician commented Jul 8, 2022

Diff report:

modular-magician commented Jul 8, 2022

Tests analytics

Action taken

modular-magician commented Jul 8, 2022

modular-magician commented Jul 8, 2022

Diff report:

modular-magician commented Jul 8, 2022

Tests analytics

Action taken

modular-magician commented Jul 8, 2022

ScottSuarez commented Jul 11, 2022

modular-magician commented Jul 11, 2022

Diff report:

modular-magician commented Jul 11, 2022

Tests analytics

Action taken

modular-magician commented Jul 11, 2022

kanata2 commented Sep 6, 2022

lodotek commented Sep 23, 2022

ScottSuarez commented Sep 23, 2022 • edited Loading

modular-magician commented Oct 14, 2022

Diff report:

modular-magician commented Oct 17, 2022

Diff report:

modular-magician commented Oct 17, 2022

Tests analytics

Action taken

modular-magician commented Oct 17, 2022

modular-magician commented Oct 17, 2022

Diff report:

modular-magician commented Oct 17, 2022

Tests analytics

Action taken

modular-magician commented Oct 17, 2022

modular-magician commented Oct 18, 2022

Diff report:

modular-magician commented Oct 18, 2022

Tests analytics

Action taken

modular-magician commented Oct 18, 2022

modular-magician commented Oct 18, 2022

Diff report:

modular-magician commented Oct 18, 2022

Tests analytics

Action taken

modular-magician commented Oct 18, 2022

ScottSuarez commented Jul 6, 2022 •

edited

Loading

ScottSuarez commented Sep 23, 2022 •

edited

Loading