Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing container cluster tests #6189

Merged
merged 2 commits into from
Jun 29, 2022

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Jun 29, 2022

fixes hashicorp/terraform-provider-google#11897
fixes hashicorp/terraform-provider-google#11898

The following tests started failing after API updates:
TestAccContainerCluster_withAddons
Fails with an internal error due to hashicorp/terraform-provider-google#11943

TestAccContainerCluster_withConfidentialNodes
node_config's min_cpu_platform can return a value from the API now.

container: fixed an issue where `node_config.min_cpu_platform` could cause a perma-diff in `google_container_cluster`

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 2 files changed, 50 insertions(+), 45 deletions(-))
Terraform Beta: Diff ( 2 files changed, 50 insertions(+), 45 deletions(-))
TF Validator: Diff ( 2 files changed, 3 insertions(+), 3 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 2062
Passed tests 1831
Skipped tests: 226
Failed tests: 5

Action taken

Triggering VCR tests in RECORDING mode for the tests that failed during VCR. Click here to see the failed tests TestAccFirebaserulesRelease_BasicRelease|TestAccContainerCluster_withAddons|TestAccContainerCluster_withConfidentialNodes|TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation|TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample

@modular-magician
Copy link
Collaborator

Tests passed during RECORDING mode:
TestAccContainerCluster_withAddons[view]
TestAccPrivatecaCertificateAuthority_privatecaCertificateAuthoritySubordinateExample[view]
TestAccPrivatecaCertificateAuthority_subordinateCaActivatedByFirstPartyIssuerOnCreation[view]
TestAccFirebaserulesRelease_BasicRelease[view]
TestAccContainerCluster_withConfidentialNodes[view]

All tests passed
View the build log or the debug log for each test

@c2thorn c2thorn requested a review from rileykarson June 29, 2022 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants