Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for Partition GPU on GKE Nodes #5315

Merged
merged 3 commits into from
Oct 18, 2021

Conversation

upodroid
Copy link
Contributor

@upodroid upodroid commented Oct 12, 2021

Fixes: hashicorp/terraform-provider-google#10231

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

container: added `node_config.0.guest_accelerator.0.gpu_partition_size` field to google_container_node_pool

@google-cla google-cla bot added the cla: yes label Oct 12, 2021
@upodroid
Copy link
Contributor Author

Can you add the hacktoberfest-accepted label? Thanks

@modular-magician
Copy link
Collaborator

Hello! I am a robot who works on Magic Modules PRs.

I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review.

Thanks for your contribution! A human will be with you soon.

@melinath, please review this PR or find an appropriate assignee.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 15 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 4 files changed, 16 insertions(+), 5 deletions(-))

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you rename this field to gpu_partition_size to match the api field name?

@upodroid
Copy link
Contributor Author

Fixed, can you add the label?

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 15 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 3 files changed, 15 insertions(+), 4 deletions(-))

@melinath
Copy link
Member

I've confirmed that we're okay with adding the label & added it. :-) /gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 15 insertions(+), 4 deletions(-))
Terraform Beta: Diff ( 3 files changed, 15 insertions(+), 4 deletions(-))

@modular-magician
Copy link
Collaborator

I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccContainerCluster_withAddons|TestAccContainerCluster_withWorkloadIdentityConfigDeprecation|TestAccContainerCluster_withWorkloadIdentityConfig|TestAccContainerNodePool_withGPU|TestAccServiceNetworkingPeeredDNSDomain_basic You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=210678

@melinath
Copy link
Member

It looks like I need to request some quota increases to get the test working. This might take a few days to get fully sorted, but as long as you're able to get the tests passing on your end I don't foresee any issues.

@melinath
Copy link
Member

First quota increase was approved quickly; re-running the test: https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloudBeta_ProviderGoogleCloudBetaMmUpstream/210855

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like that was the only quota missing. LGTM!

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh - looks like there's a merge conflict. But other than that - lgtm.

@upodroid
Copy link
Contributor Author

Fixed

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 17 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 3 files changed, 17 insertions(+), 6 deletions(-))

@melinath
Copy link
Member

/gcbrun

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 17 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 3 files changed, 17 insertions(+), 6 deletions(-))

@melinath
Copy link
Member

There was a snafu with the test run - here's a run of just the impacted test. https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloudBeta_ProviderGoogleCloudBetaMmUpstream/210902

Also since it's the weekend anyway, kicking off another /gcbrun.

@melinath melinath self-requested a review October 15, 2021 21:30
@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 3 files changed, 17 insertions(+), 6 deletions(-))
Terraform Beta: Diff ( 3 files changed, 17 insertions(+), 6 deletions(-))

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The full run failed to complete, but the specific run completed 👍 The other failures seem unrelated. LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform support for A100 GPU partitioning
3 participants