-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Support for Partition GPU on GKE Nodes #5315
Add Support for Partition GPU on GKE Nodes #5315
Conversation
Co-authored-by: upodroid <[email protected]>
Can you add the hacktoberfest-accepted label? Thanks |
Hello! I am a robot who works on Magic Modules PRs. I have detected that you are a community contributor, so your PR will be assigned to someone with a commit-bit on this repo for initial review. Thanks for your contribution! A human will be with you soon. @melinath, please review this PR or find an appropriate assignee. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you rename this field to gpu_partition_size
to match the api field name?
Fixed, can you add the label? |
I've confirmed that we're okay with adding the label & added it. :-) /gcbrun |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccContainerCluster_withAddons|TestAccContainerCluster_withWorkloadIdentityConfigDeprecation|TestAccContainerCluster_withWorkloadIdentityConfig|TestAccContainerNodePool_withGPU|TestAccServiceNetworkingPeeredDNSDomain_basic You can view the result here: https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=210678 |
It looks like I need to request some quota increases to get the test working. This might take a few days to get fully sorted, but as long as you're able to get the tests passing on your end I don't foresee any issues. |
First quota increase was approved quickly; re-running the test: https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloudBeta_ProviderGoogleCloudBetaMmUpstream/210855 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like that was the only quota missing. LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh - looks like there's a merge conflict. But other than that - lgtm.
Fixed |
/gcbrun |
There was a snafu with the test run - here's a run of just the impacted test. https://ci-oss.hashicorp.engineering/buildConfiguration/GoogleCloudBeta_ProviderGoogleCloudBetaMmUpstream/210902 Also since it's the weekend anyway, kicking off another /gcbrun. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The full run failed to complete, but the specific run completed 👍 The other failures seem unrelated. LGTM.
Fixes: hashicorp/terraform-provider-google#10231
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)