-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add override for docs sections - apply to compute and monitoring. #5257
Conversation
Oops! It looks like you're using an unknown release-note type in your changelog entries:
Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md. |
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform Beta: Diff ( 2 files changed, 5 insertions(+), 17 deletions(-)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your code makes sense and I can't see why, but it doesn't seem to have taken- this only applied to Stackdriver at TPGB.
Well, huh. I'll figure that out and ping you when it works. |
Also, before digging too deep I'd suggest rebasing on my api/ change (it touched how products are loaded a little) |
f6146c1
to
dbc4172
Compare
Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are. Diff report:Terraform Beta: Diff ( 3 files changed, 6 insertions(+), 18 deletions(-)) |
…ogleCloudPlatform#5257) * Add override for docs sections - apply to compute and monitoring. * These compute resources are actually handwritten, and the monitoring has no GA.
Fixes hashicorp/terraform-provider-google#10123.
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)