Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add override for docs sections - apply to compute and monitoring. #5257

Merged
merged 2 commits into from
Sep 30, 2021

Conversation

nat-henderson
Copy link
Contributor

@nat-henderson nat-henderson commented Sep 30, 2021

Fixes hashicorp/terraform-provider-google#10123.

If this PR is for Terraform, I acknowledge that I have:

  • Searched through the issue tracker for an open issue that this either resolves or contributes to, commented on it to claim it, and written "fixes {url}" or "part of {url}" in this PR description. If there were no relevant open issues, I opened one and commented that I would like to work on it (not necessary for very small changes).
  • Generated Terraform, and ran make test and make lint to ensure it passes unit and linter tests.
  • Ensured that all new fields I added that can be set by a user appear in at least one example (for generated resources) or third_party test (for handwritten resources or update tests).
  • Ran relevant acceptance tests (If the acceptance tests do not yet pass or you are unable to run them, please let your reviewer know).
  • Read the Release Notes Guide before writing my release note below.

Release Note Template for Downstream PRs (will be copied)

Minor docs reorganization to group all Compute Engine and Monitoring (Stackdriver) resources together.

@modular-magician
Copy link
Collaborator

Oops! It looks like you're using an unknown release-note type in your changelog entries:

  • REPLACEME

Please only use the types listed in https://github.com/GoogleCloudPlatform/magic-modules/blob/master/.ci/RELEASE_NOTES_GUIDE.md.

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 2 files changed, 5 insertions(+), 17 deletions(-))

Copy link
Member

@rileykarson rileykarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your code makes sense and I can't see why, but it doesn't seem to have taken- this only applied to Stackdriver at TPGB.

@nat-henderson
Copy link
Contributor Author

Well, huh. I'll figure that out and ping you when it works.

@rileykarson
Copy link
Member

Also, before digging too deep I'd suggest rebasing on my api/ change (it touched how products are loaded a little)

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform Beta: Diff ( 3 files changed, 6 insertions(+), 18 deletions(-))

@modular-magician
Copy link
Collaborator

Hi! I'm the modular magician. Your PR generated some diffs in downstreams - here they are.

Diff report:

Terraform GA: Diff ( 4 files changed, 15 insertions(+), 27 deletions(-))
Terraform Beta: Diff ( 7 files changed, 22 insertions(+), 47 deletions(-))

@nat-henderson nat-henderson merged commit 40aed39 into master Sep 30, 2021
@nat-henderson nat-henderson deleted the mmv2-website-section branch September 30, 2021 22:15
khajduczenia pushed a commit to khajduczenia/magic-modules that referenced this pull request Oct 12, 2021
…ogleCloudPlatform#5257)

* Add override for docs sections - apply to compute and monitoring.

* These compute resources are actually handwritten, and the monitoring has no GA.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a tpgtools override to add products to the correct website section
3 participants