-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add interface attribute to google_compute_disk #4116
add interface attribute to google_compute_disk #4116
Conversation
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=152364" |
/gcbrun |
I have triggered VCR tests based on this PR's diffs. See the results here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=152369" |
I have triggered VCR tests in RECORDING mode for the following tests that failed during VCR: TestAccDataSourceComputeImage|TestAccDataSourceComputeImageFilter|TestAccDataSourceSpannerInstance_basic|TestAccComputeDiskIamBindingGenerated|TestAccComputeDiskIamMemberGenerated|TestAccComputeDiskIamPolicyGenerated|TestAccComputeRegionDiskIamBindingGenerated|TestAccComputeRegionDiskIamMemberGenerated|TestAccComputeRegionDiskIamPolicyGenerated|TestAccProviderMeta_setModuleName|TestAccComputeAttachedDisk_basic|TestAccComputeAttachedDisk_full|TestAccComputeAttachedDisk_count|TestAccComputeDisk_diskBasicExample|TestAccComputeDiskResourcePolicyAttachment_diskResourcePolicyAttachmentBasicExample|TestAccComputeDiskResourcePolicyAttachment_update|TestAccComputeDisk_update|TestAccComputeDisk_interface|TestAccComputeDisk_fromSnapshot|TestAccComputeDisk_encryption|TestAccComputeDisk_deleteDetach|TestAccComputeDisk_resourcePolicies|TestAccComputeDisk_encryptionKMS|TestAccComputeImage_withLicense|TestAccComputeImage_basedondisk|TestAccComputeInstanceFromTemplate_basic|TestAccComputeImage_sourceSnapshot|TestAccComputeImage_resolveImage|TestAccComputeInstanceFromTemplate_overrideBootDisk|TestAccComputeInstanceFromTemplate_overrideAttachedDisk|TestAccComputeInstanceFromTemplate_overrideScheduling|TestAccComputeInstanceFromTemplate_overrideScratchDisk|TestAccComputeInstanceTemplate_disks|TestAccComputeInstanceTemplate_disksInvalid|TestAccComputeInstance_diskEncryption|TestAccComputeInstance_diskEncryptionRestart|TestAccComputeInstance_attachedDisk|TestAccComputeInstance_attachedDisk_sourceUrl|TestAccComputeInstance_attachedDiskUpdate|TestAccComputeInstance_attachedDisk_modeRo|TestAccComputeInstance_bootDisk_source|TestAccComputeInstance_bootDisk_sourceUrl|TestAccComputeInstance_bootDisk_mode|TestAccComputeInstance_bootDisk_type|TestAccComputeInstance_kmsDiskEncryption|TestAccComputeInstance_forceNewAndChangeMetadata|TestAccComputeInstance_update|TestAccComputeInstance_serviceAccount|TestAccComputeInstance_scheduling|TestAccComputeInstance_subnet_auto|TestAccComputeInstance_soleTenantNodeAffinities|TestAccComputeInstance_networkIPAuto|TestAccComputeInstance_subnet_custom|TestAccComputeInstance_forceChangeMachineTypeManually|TestAccComputeInstance_network_ip_custom|TestAccComputeInstance_private_image_family|TestAccComputeInstance_multiNic|TestAccComputeInstance_deletionProtectionExplicitFalse|TestAccComputeInstance_deletionProtectionExplicitTrueAndUpdateFalse|TestAccComputeInstance_primaryAliasIpRange|TestAccComputeInstance_secondaryAliasIpRange|TestAccComputeInstance_hostname|TestAccComputeInstance_enableDisplay|TestAccComputeInstance_shieldedVmConfig|TestAccComputeInstance_desiredStatusUpdateBasic|TestAccComputeInstance_desiredStatusTerminatedUpdateFields|TestAccComputeInstance_updateRunning_desiredStatusRunning_allowStoppingForUpdate|TestAccComputeInstance_desiredStatusOnCreation|TestAccComputeInstance_updateRunning_desiredStatusTerminated_allowStoppingForUpdate|TestAccComputeInstance_updateRunning_desiredStatusRunning_notAllowStoppingForUpdate|TestAccComputeInstance_updateRunning_desiredStatusNotSet_notAllowStoppingForUpdate|TestAccComputeInstance_updateRunning_desiredStatusTerminated_notAllowStoppingForUpdate|TestAccComputeInstance_updateTerminated_desiredStatusTerminated_allowStoppingForUpdate|TestAccComputeInstance_updateTerminated_desiredStatusRunning_allowStoppingForUpdate|TestAccComputeInstance_updateTerminated_desiredStatusNotSet_allowStoppingForUpdate|TestAccComputeInstance_updateTerminated_desiredStatusNotSet_notAllowStoppingForUpdate|TestAccComputeInstance_updateTerminated_desiredStatusRunning_notAllowStoppingForUpdate|TestAccComputeMachineImage_machineImageBasicExample|TestAccComputeInstance_updateTerminated_desiredStatusTerminated_notAllowStoppingForUpdate|TestAccComputeInstance_subnetworkUpdate|TestAccComputeNodeGroup_nodeGroupBasicExample|TestAccComputeNodeGroup_nodeGroupAutoscalingPolicyExample|TestAccComputeNodeGroup_updateNodeTemplate|TestAccComputePerInstanceConfig_update|TestAccComputePacketMirroring_computePacketMirroringFullExample|TestAccComputeRegionAutoscaler_regionAutoscalerBasicExample|TestAccComputeRegionAutoscaler_update|TestAccComputeRegionAutoscaler_scaleDownControl|TestAccComputeRegionBackendService_regionBackendServiceBalancingModeExample|TestAccComputeRegionBackendService_withBackendInternal|TestAccComputeRegionBackendService_withBackendMultiNic|TestAccComputeRegionDisk_regionDiskBasicExample|TestAccComputeRegionBackendService_basic|TestAccComputeRegionDiskResourcePolicyAttachment_regionDiskResourcePolicyAttachmentBasicExample|TestAccComputeRegionDisk_basic|TestAccComputeRegionBackendService_withBackendInternalManaged|TestAccComputeRegionDisk_basicUpdate|TestAccComputeRegionDisk_encryption|TestAccComputeRegionDisk_deleteDetach|TestAccComputeRegionBackendService_ilbUpdateFull You can view the result here: "https://ci-oss.hashicorp.engineering/viewQueued.html?itemId=152388" |
Fixes hashicorp/terraform-provider-google#7532
If this PR is for Terraform, I acknowledge that I have:
make test
andmake lint
to ensure it passes unit and linter tests.Release Note Template for Downstream PRs (will be copied)